Repository navigation
fix: skip callbacks for the selected segment - #922
Open
huytdps13400 wants to merge 1 commit into
Open
huytdps13400 wants to merge 1 commit into
huytdps13400 wants to merge 1 commit into
Conversation
huytdps13400
force-pushed
the
fix/skip-selected-segment-callbacks
branch
from
October 5, 2026 06:54
637b44f to
dcc5da9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Pressing the already selected segment currently invokes
onChangeandonValueChangeon Android and web, even though the selection has not changed. Skip those callbacks when the pressed index matches the currentselectedIndex, matching the normal iOS behavior.The comparison uses the index, so two different segments with the same label still notify correctly. The new regression suite exercises the rendered touchables, including controlled prop updates and an initially absent selection, and runs in the existing CI lint job.
Fixes #889.
Test Plan
--bracket-same-line, matching the repository's legacyjsxBracketSameLinesetting) pass.spawnerror -86). Flow validation is therefore unverified locally.