Repository navigation
Restore Fantom DevTools launching with FANTOM_DEBUG_JS (#59410) - #59410
Closed
rubennorte wants to merge 1 commit into
Closed
rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127171074. |
meta-codesync
Bot
changed the title
FANTOM_DEBUG_JSFANTOM_DEBUG_JS (#59410)
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2026
Summary: Restore DevTools launching when `FANTOM_DEBUG_JS` is set. Use a Chrome app window instead of the standalone shell, which can fail to start in restricted launch environments. Request DevTools from the runner after the inspector target registers, deduplicate launch requests for each tester connection, and run debugging sessions in band. Report failed launcher commands in the test output. Changelog: [Internal] Differential Revision: D127171074
rubennorte
force-pushed
the
export-D127171074
branch
2 times, most recently
from
October 26, 2026 11:35
8f11048 to
933431a
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Restore DevTools launching when `FANTOM_DEBUG_JS` is set by reusing the existing browser launcher with an explicit opt-in for interactive test debugging. Use a Chrome app window, request DevTools after the inspector target registers, deduplicate launch requests for each tester connection, and run debugging sessions in band. Preserve launcher failures in the test output. Changelog: [Internal] Reviewed By: lenaic, andrewdacenko Differential Revision: D127171074
Summary: Restore DevTools launching when `FANTOM_DEBUG_JS` is set by allowing the existing native tester to launch through the shared browser launcher. Explicitly allow app launching for interactive test debugging, use a Chrome app window instead of the standalone shell, and run debugging sessions in band. Changelog: [Internal] Reviewed By: lenaic, andrewdacenko Differential Revision: D127171074
rubennorte
force-pushed
the
export-D127171074
branch
from
October 26, 2026 11:51
933431a to
872e920
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Restore DevTools launching when `FANTOM_DEBUG_JS` is set by allowing the existing native tester to launch through the shared browser launcher. Explicitly allow app launching for interactive test debugging, use a Chrome app window instead of the standalone shell, and run debugging sessions in band. Changelog: [Internal] Reviewed By: lenaic, andrewdacenko Differential Revision: D127171074
rubennorte
force-pushed
the
export-D127171074
branch
2 times, most recently
from
October 26, 2026 11:51
cc72bee to
872e920
Compare
Collaborator
|
This pull request was successfully merged by @rubennorte in bd2074c When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in bd2074c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Restore DevTools launching when
FANTOM_DEBUG_JSis set by allowing the existing native tester to launch through the shared browser launcher. Explicitly allow app launching for interactive test debugging, use a Chrome app window instead of the standalone shell, and run debugging sessions in band.Changelog: [Internal]
Reviewed By: lenaic, andrewdacenko
Differential Revision: D127171074