Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
cortinico
marked this pull request as ready for review
October 26, 2026 14:04
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D127578936. |
Collaborator
|
This pull request was successfully merged by @cortinico in 6ebb129 When will my fix make it into a release? | How to file a pick request? |
|
@cortinico merged this pull request in 6ebb129. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Visual capture on main (run https://github.com/react/react-native/actions/runs/40319678403) failed almost every iOS flow at the shared "Components is visible" precondition, including retries. The helper currently requires RNTester to show its home screen before sending a direct example deep link. A relaunched app can instead restore another screen. Send the deep link immediately after launch; each flow already waits for and asserts its target example before taking screenshots. This lets later flows recover if an earlier flow leaves the app off the home screen.
The first border flow also failed at an example assertion, so this change may not resolve all failures in that run. iOS capture CI is needed to verify the behavior.
Changelog:
[INTERNAL] [FIXED] - Allow visual capture to recover from RNTester reopening away from the home screen.
Test Plan:
yarn test .github/workflow-scripts/__tests__/visual-capture-test.js --runInBand— 10 tests passed.yarn prettier --check packages/rn-tester/visual-tests/helpers/open-example.yml— passed.git diff --check— passed.