Extend CI workflow with JSROOT test job - #95
Merged
Conversation
hahnjo
reviewed
Aug 19, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
We'll also need to figure out a way how to deal with currently released JSROOT failing in structure/empty. Maybe we can check the version and manually skip the test in read.mjs?
hahnjo
reviewed
Aug 19, 2026
undefined-panda
force-pushed
the
jsroot-ci
branch
3 times, most recently
from
August 19, 2026 13:57
ce54526 to
9a956f1
Compare
hahnjo
reviewed
Aug 20, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but the exported HTML is currently all red because the fixes are not yet in a released version of JSROOT. I'm not sure what we can do about that, maybe also skip structure/cluster_groups, types/fundamental/integer, and types/fundamental/real32quant?
undefined-panda
force-pushed
the
jsroot-ci
branch
from
August 21, 2026 07:52
9a956f1 to
a48f042
Compare
undefined-panda
force-pushed
the
jsroot-ci
branch
from
August 21, 2026 07:57
a48f042 to
49f1c43
Compare
hahnjo
reviewed
Aug 21, 2026
undefined-panda
force-pushed
the
jsroot-ci
branch
from
August 21, 2026 15:35
49f1c43 to
3e4e9e7
Compare
hahnjo
reviewed
Aug 25, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
Last few minor comments (hopefully)
undefined-panda
force-pushed
the
jsroot-ci
branch
3 times, most recently
from
August 25, 2026 08:57
fd227b0 to
4e37153
Compare
List of skipped tests: - structure/empty - structure/cluster_groups - types/fundamental/integer - types/fundamental/real32quant
undefined-panda
force-pushed
the
jsroot-ci
branch
from
August 25, 2026 08:59
4e37153 to
3248deb
Compare
hahnjo
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate JSROOT into the cross-validation pipeline. When triggering the workflow manually via
workflow_dispatch, JSROOT tests can be disabled via a checkbox input.