Skip to content

Remove custom ament_cppcheck usage. - #3398

Merged
clalancette merged 1 commit into
rollingfrom
clalancette/remove-cppcheck
Nov 2, 2026
Merged

clalancette merged 1 commit into
rollingfrom
clalancette/remove-cppcheck

Conversation

@clalancette

Copy link
Copy Markdown
Contributor

Description

ament_cppcheck has been effectively dead since 2022, when it was disabled for the 2.x versions having very long scan times. We haven't seemed to miss it in the intervening 4 years, so I think it is time to stop using it at all. Remove the custom ament_cppcheck setup in this repository.

Is this user-facing behavior change?

No.

Did you use Generative AI?

Claude Opus 5.5

Additional Information

This is a part of a larger series that aims to remove ament_cppcheck from ament_lint_auto, and eventually to remove the module altogether.

ament_cppcheck has been effectively dead since 2022, when it was disabled for
the 2.x versions having very long scan times.  We haven't seemed to miss it
in the intervening 4 years, so I think it is time to stop using it at all.
Remove the custom ament_cppcheck setup in this repository.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

ABI Compliance Check

✅ Verdict: compatible

Library Verdict Summary
libcomponent_manager.so ✅ compatible No ABI changes detected.
librclcpp.so ✅ compatible No ABI changes detected.
librclcpp_action.so ✅ compatible No ABI changes detected.
librclcpp_lifecycle.so ✅ compatible No ABI changes detected.
✅ libcomponent_manager.so — full abidiff report

Compared:

  • Base: lib-base/libcomponent_manager.so
  • Head: lib-pr/libcomponent_manager.so @ e20ab7d
(empty report — no differences printed by abidiff)
✅ librclcpp.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp.so
  • Head: lib-pr/librclcpp.so @ e20ab7d
(empty report — no differences printed by abidiff)
✅ librclcpp_action.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_action.so
  • Head: lib-pr/librclcpp_action.so @ e20ab7d
(empty report — no differences printed by abidiff)
✅ librclcpp_lifecycle.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_lifecycle.so
  • Head: lib-pr/librclcpp_lifecycle.so @ e20ab7d
(empty report — no differences printed by abidiff)

Updated for commit e20ab7d · check run · suppressions: /home/runner/work/_temp/ros2-abi-suppressions.txt

@clalancette

Copy link
Copy Markdown
Contributor Author

@clalancette
clalancette merged commit a36c756 into rolling Nov 2, 2026
10 of 11 checks passed
@clalancette
clalancette deleted the clalancette/remove-cppcheck branch November 2, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants