Repository navigation
Remove custom ament_cppcheck usage. - #3398
Merged
Merged
Conversation
ament_cppcheck has been effectively dead since 2022, when it was disabled for the 2.x versions having very long scan times. We haven't seemed to miss it in the intervening 4 years, so I think it is time to stop using it at all. Remove the custom ament_cppcheck setup in this repository. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ABI Compliance Check✅ Verdict: compatible
✅
|
ahcorde
approved these changes
Nov 2, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ament_cppcheck has been effectively dead since 2022, when it was disabled for the 2.x versions having very long scan times. We haven't seemed to miss it in the intervening 4 years, so I think it is time to stop using it at all. Remove the custom ament_cppcheck setup in this repository.
Is this user-facing behavior change?
No.
Did you use Generative AI?
Claude Opus 5.5
Additional Information
This is a part of a larger series that aims to remove ament_cppcheck from ament_lint_auto, and eventually to remove the module altogether.