Skip to content

mir-transform: Remove is_optimization_stage - #161413

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
clubby789:remove-is-optimization
Sep 11, 2026
Merged

mir-transform: Remove is_optimization_stage#161413
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
clubby789:remove-is-optimization

Conversation

@clubby789

@clubby789 clubby789 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Based on #160524 until that one is merged

#160524 (comment)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2026
@rustbot

rustbot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

RalfJung is not on the review rotation at the moment.
They may take a while to respond.

@RalfJung

Copy link
Copy Markdown
Member

I'm not that familiar with the bisecting code or why it added a new pass classification in is_optimization_stage ... it was added in #152474.
Cc @sgasho r? @saethlin

@rustbot rustbot assigned saethlin and unassigned RalfJung Aug 20, 2026
@rust-bors

This comment has been minimized.

@clubby789
clubby789 force-pushed the remove-is-optimization branch from 1411960 to f59ff9d Compare September 7, 2026 16:25
@clubby789

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 7, 2026
@clubby789
clubby789 marked this pull request as ready for review September 7, 2026 16:26
@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@saethlin

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f59ff9d has been approved by saethlin

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 11, 2026
…r=saethlin

mir-transform: Remove `is_optimization_stage`

Based on rust-lang#160524 until that one is merged

rust-lang#160524 (comment)
@rust-bors

rust-bors Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit f59ff9d with merge 62d1a16...

Workflow: https://github.com/rust-lang/rust/actions/runs/34637145365

rust-bors Bot pushed a commit that referenced this pull request Sep 11, 2026
mir-transform: Remove `is_optimization_stage`

Based on #160524 until that one is merged

#160524 (comment)
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors yield
Yielding to enclosing rollup

@rust-bors

rust-bors Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #162664.

rust-bors Bot pushed a commit that referenced this pull request Sep 11, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #161413 (mir-transform: Remove `is_optimization_stage`)
 - #161430 (Re-export `core::fmt::NumBuffer` in `alloc` (and `std`))
 - #162446 (Prevent `should-fail` to be used in `rustdoc-ui` testsuite)
 - #162621 (Clarify examples related to `Sync` and `SyncView`)
 - #162650 (Initialize mingw for all mingw targets)
 - #162651 (Remove needless test running instructions)
 - #162658 (Remove noras target docs mention)
@rust-bors
rust-bors Bot merged commit 87840b1 into rust-lang:main Sep 11, 2026
13 of 14 checks passed
rust-bors Bot pushed a commit that referenced this pull request Sep 11, 2026
Rollup merge of #161413 - clubby789:remove-is-optimization, r=saethlin

mir-transform: Remove `is_optimization_stage`

Based on #160524 until that one is merged

#160524 (comment)
@rustbot rustbot added this to the 1.100.0 milestone Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants