Rename various resolving functions for consistency, and document them by jdonszelmann · Pull Request #162126 · rust-lang/rust

jdonszelmann · 2026-09-01T13:16:35Z

r? @lcnr or anyone in @rust-lang/initiative-trait-system-refactor

This is all changes from https://github.com/rust-lang/rust/pull/160913/changes that are just renames. Updating that PR to be just the logic changes

All interesting changes happened in rustc_infer/src/infer/mod.rs across all commits. Everything else is renames propagating through other files.

The functions are now called:

before	after	note
`shallow_resolve_*`	(unchanged) `shallow_resolve_*`	Now with newly added docs.
`resolve_vars_if_possible_*`	`deeply_resolve_ignoring_regions_*`
`eager_resolve_vars`	`deeply_resolve_via_unification_table`	moved onto the `InferCtxtLike` as an inherent method with default body.
`fully_resolve`	`deeply_resolve_via_region_graph`	Resolves with regions and asserts that all variables are resolved at the end. Note, we only use this function 3x so the long name is ok, it shouldn't be your go-to anyway.
`opportunistic_resolve_var`		gone, same as `shalllow_resolve` now that we resolve to roots

Note

I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.

rustbot · 2026-09-01T13:16:39Z

changes to inspect_obligations.rs

cc @lcnr

changes to the core type system

cc @lcnr

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in need_type_info.rs

cc @lcnr

BoxyUwU · 2026-09-01T13:27:15Z

bikeshed: fully_resolve to deeply_resolve_and_assert_blah or sth? it feels odd to me that there wouldnt be a naming similarity between fully_resolve and all the other methods

jdonszelmann · 2026-09-01T13:46:51Z

hm, I do like that, lemme change that @BoxyUwU :)

BoxyUwU

Seems reasonable enough 🤔 It feels a little unfortunate that we lose "var" being in the name of resolve_vars_if_possible. It's also a little unfortunate that deeply_resolve has naming similarities with deeply_normalize which errors if it can't normalize sth, whereas deeply_normalize is fine if it can't resolve something 🤔

I do like the new names more though since they feel more internally consistent with eachother

View changes since this review

BoxyUwU · 2026-09-08T11:44:03Z

@rustbot author (conflicts)

rustbot · 2026-09-08T11:44:07Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

jdonszelmann · 2026-09-08T12:19:52Z

@rustbot review

rust-bors · 2026-09-11T10:44:55Z

This pull request was unapproved.

This PR was contained in a rollup (#162629), which was unapproved.

View changes since this unapproval

jdonszelmann · 2026-09-11T10:59:57Z

ugh, I think this should fix it. @bors r=lcnr, BoxyUwU

rust-bors · 2026-09-11T11:00:00Z

📌 Commit f4fd639 has been approved by lcnr,

It is now in the queue for this repository.

⚠️ The following reviewer(s) could not be found: ``

jdonszelmann · 2026-09-11T11:00:21Z

@bors r-

jdonszelmann · 2026-09-11T11:00:25Z

@bors r=lcnr,BoxyUwU

rust-bors · 2026-09-11T11:00:25Z

This pull request was unapproved.

View changes since this unapproval

rust-bors · 2026-09-11T11:00:28Z

📌 Commit f4fd639 has been approved by lcnr,BoxyUwU

It is now in the queue for this repository.

@lcnr

…cnr,BoxyUwU Rename various resolving functions for consistency, and document them r? @lcnr or anyone in @rust-lang/initiative-trait-system-refactor This is all changes from https://github.com/rust-lang/rust/pull/160913/changes that are *just* renames. Updating that PR to be *just* the logic changes All interesting changes happened in `rustc_infer/src/infer/mod.rs` across all commits. Everything else is renames propagating through other files. The functions are now called: | before | after | note | |---|---|---| | `shallow_resolve_*` | (unchanged) `shallow_resolve_*` | Now with newly added docs. | | `resolve_vars_if_possible_*` | `deeply_resolve_ignoring_regions_*` | | | `eager_resolve_vars` | `deeply_resolve_via_unification_table` | moved onto the `InferCtxtLike` as an inherent method with default body. | | `fully_resolve` |`deeply_resolve_via_region_graph` | Resolves *with* regions and asserts that all variables are resolved at the end. Note, we only use this function 3x so the long name is ok, it shouldn't be your go-to anyway. | | `opportunistic_resolve_var` | | gone, same as `shalllow_resolve` now that we resolve to roots | > [!NOTE] > I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.

…uwer Rollup of 5 pull requests Successful merges: - #162126 (Rename various resolving functions for consistency, and document them) - #160681 (Respect `--all-targets` flag when checking the compiler) - #162580 (Parallel frontend: reproducible coroutine_by_move_body_def_id ) - #162614 (add regression test for RPITIT fulfillment error) - #162626 (Move `riscv64im-unknown-none-elf` to Tier 3 table)

rust-bors · 2026-09-11T15:17:08Z

⌛ Testing commit f4fd639 with merge 9d0a292...

Workflow: https://github.com/rust-lang/rust/actions/runs/34615212472

@lcnr

Rename various resolving functions for consistency, and document them r? @lcnr or anyone in @rust-lang/initiative-trait-system-refactor This is all changes from https://github.com/rust-lang/rust/pull/160913/changes that are *just* renames. Updating that PR to be *just* the logic changes All interesting changes happened in `rustc_infer/src/infer/mod.rs` across all commits. Everything else is renames propagating through other files. The functions are now called: | before | after | note | |---|---|---| | `shallow_resolve_*` | (unchanged) `shallow_resolve_*` | Now with newly added docs. | | `resolve_vars_if_possible_*` | `deeply_resolve_ignoring_regions_*` | | | `eager_resolve_vars` | `deeply_resolve_via_unification_table` | moved onto the `InferCtxtLike` as an inherent method with default body. | | `fully_resolve` |`deeply_resolve_via_region_graph` | Resolves *with* regions and asserts that all variables are resolved at the end. Note, we only use this function 3x so the long name is ok, it shouldn't be your go-to anyway. | | `opportunistic_resolve_var` | | gone, same as `shalllow_resolve` now that we resolve to roots | > [!NOTE] > I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.

JonathanBrouwer · 2026-09-11T15:58:41Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-09-11T15:58:45Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/34615212472

The next pull request likely to be tested is #162640.

…uwer Rollup of 5 pull requests Successful merges: - #162126 (Rename various resolving functions for consistency, and document them) - #160681 (Respect `--all-targets` flag when checking the compiler) - #162580 (Parallel frontend: reproducible coroutine_by_move_body_def_id ) - #162614 (add regression test for RPITIT fulfillment error) - #162626 (Move `riscv64im-unknown-none-elf` to Tier 3 table)

@lcnr

Rollup merge of #162126 - jdonszelmann:rename-resolving, r=lcnr,BoxyUwU Rename various resolving functions for consistency, and document them r? @lcnr or anyone in @rust-lang/initiative-trait-system-refactor This is all changes from https://github.com/rust-lang/rust/pull/160913/changes that are *just* renames. Updating that PR to be *just* the logic changes All interesting changes happened in `rustc_infer/src/infer/mod.rs` across all commits. Everything else is renames propagating through other files. The functions are now called: | before | after | note | |---|---|---| | `shallow_resolve_*` | (unchanged) `shallow_resolve_*` | Now with newly added docs. | | `resolve_vars_if_possible_*` | `deeply_resolve_ignoring_regions_*` | | | `eager_resolve_vars` | `deeply_resolve_via_unification_table` | moved onto the `InferCtxtLike` as an inherent method with default body. | | `fully_resolve` |`deeply_resolve_via_region_graph` | Resolves *with* regions and asserts that all variables are resolved at the end. Note, we only use this function 3x so the long name is ok, it shouldn't be your go-to anyway. | | `opportunistic_resolve_var` | | gone, same as `shalllow_resolve` now that we resolve to roots | > [!NOTE] > I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2026

rustbot assigned lcnr Sep 1, 2026

jdonszelmann force-pushed the rename-resolving branch from e7c7eb0 to c502d33 Compare September 1, 2026 13:23

jdonszelmann changed the title ~~Rename various resolving functions~~ Rename various resolving functions for consistencym and document them Sep 1, 2026

jdonszelmann changed the title ~~Rename various resolving functions for consistencym and document them~~ Rename various resolving functions for consistency, and document them Sep 1, 2026

jdonszelmann mentioned this pull request Sep 1, 2026

Clean up and speed up inference variable resolving code #160913

Open

This comment has been minimized.

Sign in to view

BoxyUwU reviewed Sep 1, 2026

View reviewed changes

Comment thread compiler/rustc_infer/src/infer/outlives/obligations.rs

BoxyUwU approved these changes Sep 1, 2026

View reviewed changes

BoxyUwU self-assigned this Sep 2, 2026

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026

jdonszelmann force-pushed the rename-resolving branch from 9ccba2c to f460ebb Compare September 8, 2026 12:19

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the rename-resolving branch from f460ebb to add7372 Compare September 8, 2026 12:19

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 8, 2026

jdonszelmann force-pushed the rename-resolving branch from add7372 to 77a00bd Compare September 8, 2026 13:57

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 11, 2026

jdonszelmann added 2 commits September 11, 2026 12:50

make deeply_resolve a method on InferCtxtLike

e0586ca

rename fully_resolve to deeply_resolve_and_assert_fully_resolved

f4fd639

jdonszelmann force-pushed the rename-resolving branch from 532134e to f4fd639 Compare September 11, 2026 10:59

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 11, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 11, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2026

This was referenced Sep 11, 2026

Rollup of 5 pull requests #162636

Closed

Rollup of 5 pull requests #162640

Merged

rust-bors Bot merged commit e6b92f8 into rust-lang:main Sep 11, 2026
13 of 14 checks passed

rustbot added this to the 1.100.0 milestone Sep 11, 2026

Uh oh!

Uh oh!

Conversation

jdonszelmann commented Sep 1, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 1, 2026

Uh oh!

BoxyUwU commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Sep 1, 2026

Uh oh!

This comment has been minimized.

Uh oh!

BoxyUwU left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

BoxyUwU commented Sep 8, 2026

Uh oh!

rustbot commented Sep 8, 2026

Uh oh!

This comment has been minimized.

jdonszelmann commented Sep 8, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 11, 2026

Uh oh!

jdonszelmann commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

jdonszelmann commented Sep 11, 2026

Uh oh!

jdonszelmann commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jdonszelmann commented Sep 1, 2026 •

edited by rustbot

Loading

BoxyUwU commented Sep 1, 2026 •

edited

Loading

BoxyUwU left a comment •

edited by rustbot

Loading

rust-bors Bot commented Sep 11, 2026 •

edited

Loading