Rollup of 5 pull requests by JonathanBrouwer · Pull Request #162640 · rust-lang/rust

JonathanBrouwer · 2026-09-11T13:42:20Z

Successful merges:

Rename various resolving functions for consistency, and document them #162126 (Rename various resolving functions for consistency, and document them)
Respect --all-targets flag when checking the compiler #160681 (Respect --all-targets flag when checking the compiler)
Parallel frontend: reproducible coroutine_by_move_body_def_id #162580 (Parallel frontend: reproducible coroutine_by_move_body_def_id )
add regression test for RPITIT fulfillment error #162614 (add regression test for RPITIT fulfillment error)
Move riscv64im-unknown-none-elf to Tier 3 table #162626 (Move riscv64im-unknown-none-elf to Tier 3 table)

…ialization to make DefId creation in it deterministic

Instead of Tier 2 without host tools table.

@lcnr

…cnr,BoxyUwU Rename various resolving functions for consistency, and document them r? @lcnr or anyone in @rust-lang/initiative-trait-system-refactor This is all changes from https://github.com/rust-lang/rust/pull/160913/changes that are *just* renames. Updating that PR to be *just* the logic changes All interesting changes happened in `rustc_infer/src/infer/mod.rs` across all commits. Everything else is renames propagating through other files. The functions are now called: | before | after | note | |---|---|---| | `shallow_resolve_*` | (unchanged) `shallow_resolve_*` | Now with newly added docs. | | `resolve_vars_if_possible_*` | `deeply_resolve_ignoring_regions_*` | | | `eager_resolve_vars` | `deeply_resolve_via_unification_table` | moved onto the `InferCtxtLike` as an inherent method with default body. | | `fully_resolve` |`deeply_resolve_via_region_graph` | Resolves *with* regions and asserts that all variables are resolved at the end. Note, we only use this function 3x so the long name is ok, it shouldn't be your go-to anyway. | | `opportunistic_resolve_var` | | gone, same as `shalllow_resolve` now that we resolve to roots | > [!NOTE] > I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.

…, r=jieyouxu Respect `--all-targets` flag when checking the compiler Chris was trying to get `x check library --all-targets` working in https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Checking.20std.20tests.20without.20building/with/613735399. I took a look into this and realized that the `x check --all-targets` flag is literally unused - nothing in bootstrap was reading it. So the compiler and library were never checked with `--all-targets`, but on the other hands all tools are checked with `--all-targets` (or equivalent) by default, even without the flag. The library seems to be broken with `x check --all-targets`, but compiler works. This PR thus enables `--all-targets` for the compiler. Tools are still checked with all targets unconditionally.

@petrochenkov

…body, r=petrochenkov Parallel frontend: reproducible coroutine_by_move_body_def_id Adds test for and fixes `DefId` creation reproducibility issue in `coroutine_by_move_body_def_id` that came up in rust-lang#162202 r? @petrochenkov

…regression, r=petrochenkov add regression test for RPITIT fulfillment error Closes rust-lang#159680

…f-target-tier-docs, r=JohnTitor Move `riscv64im-unknown-none-elf` to Tier 3 table Instead of Tier 2 without host tools table. Noticed when looking at `i686-pc-windows-msvc` target docs and rust-lang#113739.

JonathanBrouwer · 2026-09-11T13:42:30Z

@bors r+ p=5

rust-bors · 2026-09-11T13:42:32Z

📌 Commit c6fc90a has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 5 pull requests Successful merges: - #162126 (Rename various resolving functions for consistency, and document them) - #160681 (Respect `--all-targets` flag when checking the compiler) - #162580 (Parallel frontend: reproducible coroutine_by_move_body_def_id ) - #162614 (add regression test for RPITIT fulfillment error) - #162626 (Move `riscv64im-unknown-none-elf` to Tier 3 table)

rust-bors · 2026-09-11T15:17:04Z

💔 Test for 3c4d262 failed: CI. Failed job:

auto - dist-various-1 (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-09-11T15:58:21Z

@bors retry

rust-bors · 2026-09-11T19:05:04Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 6m 4s
Pushing 3fbb92e to main...

github-actions · 2026-09-11T19:08:53Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ada41e1 (parent) -> 3fbb92e (this PR)

Test differences

Show 51 test diffs

Stage 1

[ui] tests/ui/traits/next-solver/diagnostics/rpitit-fulfillment-error.rs: [missing] -> pass (J2)
[ui (polonius)] tests/ui/traits/next-solver/diagnostics/rpitit-fulfillment-error.rs: [missing] -> pass (J4)
[run-make] tests/run-make/parallel-reproducible-by-move-body: [missing] -> pass (J6)

Stage 2

[run-make] tests/run-make/parallel-reproducible-by-move-body: [missing] -> ignore (ignored when the operating system and target environment are windows-gnu) (J0)
[ui] tests/ui/traits/next-solver/diagnostics/rpitit-fulfillment-error.rs: [missing] -> pass (J1)
[run-make] tests/run-make/parallel-reproducible-by-move-body: [missing] -> ignore (ignored when cross-compiling) (J3)
[run-make] tests/run-make/parallel-reproducible-by-move-body: [missing] -> pass (J5)

Additionally, 44 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3fbb92e14159dd8b9bdb81e065883d1132e5abb7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-freebsd: 1h 3m -> 1h 35m (+50.6%)
test-x86_64-gnu-stdlib-semver-check: 16m 25s -> 9m 28s (-42.3%)
test-x86_64-gnu: 1h 49m -> 2h 33m (+39.9%)
test-i686-msvc: 2h 24m -> 1h 31m (-36.6%)
test-x86_64-gnu-gcc-core-tests: 17m 33s -> 11m 51s (-32.5%)
test-x86_64-mingw-2: 1h 42m -> 2h 15m (+31.9%)
dist-x86_64-illumos: 1h 25m -> 1h 52m (+30.6%)
dist-s390x-linux: 1h 11m -> 1h 33m (+30.6%)
test-i686-gnu-1: 2h 22m -> 1h 41m (-29.1%)
test-x86_64-rust-for-linux: 1h 1m -> 44m 8s (-27.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-bors · 2026-09-11T20:06:44Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#162126	Rename various resolving functions for consistency, and doc…	`c8c5b351beefa8fcacd7a744e171dd94dc2bc03f` (link)
#160681	Respect `--all-targets` flag when checking the compiler	`4715664bf928f54e52fbbc287eaec408a8bbbe41` (link)
#162580	Parallel frontend: reproducible coroutine_by_move_body_def_…	`27ae82c2a9a270eeec520bece3cd110190b52984` (link)
#162614	add regression test for RPITIT fulfillment error	`937573842a229fbd36510f93e58853df8b136f6a` (link)
#162626	Move `riscv64im-unknown-none-elf` to Tier 3 table	`8db7ab60d550bcab6e9d9a705a2f21e432e3c999` (link)

parent commit: ada41e1ce8

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-09-11T20:49:56Z

Finished benchmarking commit (3fbb92e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.1%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-2.2%, -1.2%]	3
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-1.1%	[-2.2%, 0.4%]	4

Cycles

Results (primary -0.3%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.4%, 2.2%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-2.6%, -0.6%]	9
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-0.3%	[-2.6%, 2.2%]	17

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	85
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.0%]	59
All ❌✅ (primary)	-0.1%	[-0.2%, -0.0%]	85

Bootstrap: 497.659s -> 492.981s (-0.94%)
Artifact size: 406.94 MiB -> 406.85 MiB (-0.02%)

Kobzol and others added 15 commits September 7, 2026 10:26

Respect check --all-targets

41d32bf

test async closure reproducibility with the parallel frontend

704858c

remove parallelization from needs_coroutinve_by_move_body_def_id init…

8b395fe

…ialization to make DefId creation in it deterministic

add regression test for RPITIT fulfillment error

3fbfa0c

Move riscv64im-unknown-none-elf to Tier 3 table

360193f

Instead of Tier 2 without host tools table.

rename resolver folders and their access functions

ff820f4

rename opportunistic_resolve to shallow_resolve

2499f6f

better document various functions around resolve

b202d6f

make deeply_resolve a method on InferCtxtLike

e0586ca

rename fully_resolve to deeply_resolve_and_assert_fully_resolved

f4fd639

Rollup merge of rust-lang#162614 - malezjaa:rpitit-fulfillment-error-…

57e269e

…regression, r=petrochenkov add regression test for RPITIT fulfillment error Closes rust-lang#159680

Rollup merge of rust-lang#162626 - jieyouxu:riscv64im-unknown-none-el…

c6fc90a

…f-target-tier-docs, r=JohnTitor Move `riscv64im-unknown-none-elf` to Tier 3 table Instead of Tier 2 without host tools table. Noticed when looking at `i686-pc-windows-msvc` target docs and rust-lang#113739.

rust-bors Bot added the rollup A PR which is a rollup label Sep 11, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 11, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2026

rust-bors Bot mentioned this pull request Sep 11, 2026

Rename various resolving functions for consistency, and document them #162126

Merged

This comment has been minimized.

Sign in to view

rust-bors Bot added the merged-by-bors This PR was explicitly merged by bors. label Sep 11, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 11, 2026

rust-bors Bot merged commit 3fbb92e into rust-lang:main Sep 11, 2026
14 checks passed

rustbot added this to the 1.100.0 milestone Sep 11, 2026

Navigation Menu

Uh oh!

Uh oh!

Rollup of 5 pull requests - #162640

Rollup of 5 pull requests#162640
rust-bors[bot] merged 15 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-IxgJVAv

JonathanBrouwer commented Sep 11, 2026

Uh oh!

JonathanBrouwer commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 11, 2026

Uh oh!

JonathanBrouwer commented Sep 11, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 11, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 11, 2026

Stage 1

Stage 2

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

rust-timer commented Sep 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Sep 11, 2026

Uh oh!

JonathanBrouwer commented Sep 11, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 11, 2026

Uh oh!

JonathanBrouwer commented Sep 11, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 11, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 11, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

rust-timer commented Sep 11, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants