Repository navigation
Make the documentation scope a sub-scope of the object scope - #164279
Merged
rust-bors[bot] merged 2 commits intoOct 16, 2026
Merged
rust-bors[bot] merged 2 commits into
rust-bors[bot] merged 2 commits into
Conversation
Collaborator
|
These commits modify Please ensure that if you've changed the output:
cc @obi1kenobi |
rustbot
added
A-run-make
Member
Author
|
cc @weihanglo |
Member
|
This likely help a lot in these issues:
where we were discussing what scope to pass. If |
Urgau
force-pushed
the
documentation-scope-as-sub-scope-of-object
branch
from
October 15, 2026 16:34
78a3248 to
432a29b
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@GuillaumeGomez #164278 was merged and I rebased. This PR is ready for review. |
GuillaumeGomez
approved these changes
Oct 15, 2026
Member
|
That was a quick/easy review. :) Thanks! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 15, 2026
…cope-of-object, r=GuillaumeGomez Make the `documentation` scope a sub-scope of the `object` scope ~~First commit from rust-lang#164278.~~ This PR moves the `documentation` scope to be a sub-scope of the `object` scope. The `object` scope is currently defined to be: "This ensures all paths in compiled executables, libraries and objects outputs are remapped but not elsewhere", which can be translated to mean everything written to disk by `rustc` it-self. It is therefore a natural extension for the `documentation` scope to be a sub-scope of it, like `macro`, `debuginfo` and `coverage`, since we use it for things written down on disk, like rustdoc-json (with rust-lang#164278 at-least) or the source code viewer.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 15, 2026
…cope-of-object, r=GuillaumeGomez Make the `documentation` scope a sub-scope of the `object` scope ~~First commit from rust-lang#164278.~~ This PR moves the `documentation` scope to be a sub-scope of the `object` scope. The `object` scope is currently defined to be: "This ensures all paths in compiled executables, libraries and objects outputs are remapped but not elsewhere", which can be translated to mean everything written to disk by `rustc` it-self. It is therefore a natural extension for the `documentation` scope to be a sub-scope of it, like `macro`, `debuginfo` and `coverage`, since we use it for things written down on disk, like rustdoc-json (with rust-lang#164278 at-least) or the source code viewer.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 15, 2026
…uwer Rollup of 8 pull requests Successful merges: - #164271 (Add release notes for 1.99.1) - #164361 (delegation: map return even if there is no target expression) - #162778 (rustdoc: add disambiguators for identically named method in sidebar) - #163224 ([rustdoc] Add tabs to settings popover) - #164220 (Test the interaction between `--remap-path-prefix` and doctests) - #164279 (Make the `documentation` scope a sub-scope of the `object` scope) - #164318 (Fix check with `is_impl_trait_in_trait()` before expecting local id) - #164360 (Fix(lib/sys): Restore Win7 compilation)
Member
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #164382 (comment) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#164382), which was unapproved. |
Member
Author
|
@bors r=GuillaumeGomez |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
…uwer Rollup of 8 pull requests Successful merges: - #162467 (handle trait solver overflow in `codegen_select_candidate`) - #164111 (Fix: Construct byte string valtree array type using literal length) - #164227 (refine: respect recursion limit in RPITIT collector to prevent stack overflow) - #164279 (Make the `documentation` scope a sub-scope of the `object` scope) - #164353 (Update LoongArch64 Linux dist builder to LLVM 23) - #164365 (Avoid erased region on transmutability) - #164419 (cargotest: update xsv libc for RISC-V) - #164422 (Implement after-stack-frame-init-hook)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
Rollup merge of #164279 - Urgau:documentation-scope-as-sub-scope-of-object, r=GuillaumeGomez Make the `documentation` scope a sub-scope of the `object` scope ~~First commit from #164278.~~ This PR moves the `documentation` scope to be a sub-scope of the `object` scope. The `object` scope is currently defined to be: "This ensures all paths in compiled executables, libraries and objects outputs are remapped but not elsewhere", which can be translated to mean everything written to disk by `rustc` it-self. It is therefore a natural extension for the `documentation` scope to be a sub-scope of it, like `macro`, `debuginfo` and `coverage`, since we use it for things written down on disk, like rustdoc-json (with #164278 at-least) or the source code viewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit from #164278.This PR moves the
documentationscope to be a sub-scope of theobjectscope.The
objectscope is currently defined to be: "This ensures all paths in compiled executables, libraries and objects outputs are remapped but not elsewhere", which can be translated to mean everything written to disk byrustcit-self.It is therefore a natural extension for the
documentationscope to be a sub-scope of it, likemacro,debuginfoandcoverage, since we use it for things written down on disk, like rustdoc-json (with #164278 at-least) or the source code viewer.r? @GuillaumeGomez