Repository navigation
Rollup of 8 pull requests - #164382
Closed
JonathanBrouwer wants to merge 23 commits into
Closed
Rollup of 8 pull requests#164382JonathanBrouwer wants to merge 23 commits into
JonathanBrouwer wants to merge 23 commits into
Conversation
(cherry picked from commit d1e0df5)
9c1eb80 broke the compilation of all the Windows 7 targets. The mistake is trivial though: a `cfg` attribute remnant. Indeed, the `is_console` function internally handles the Win7 case already, so is effectively always available. This therefore removes the extraneous attribute in order to fix the Win7 compilation. Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
Another small issue introduced by the same commit are some warnings about `MaybeUninit` and other C constants being unused in the modules modified here. This is also a trivial oversight: it is now only used under non-Win7 targets. This therefore fixes that by gating the import and the definitions adequately. Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
Add release notes for 1.99.1 This is copied from rust-lang#164232.
…en-no-target-expr, r=petrochenkov delegation: map return even if there is no target expression When we can perform `Self` mapping and there is no target expression we still should map the return value. Part of rust-lang#118212. r? @petrochenkov
…big-142147, r=GuillaumeGomez rustdoc: add disambiguators for identically named method in sidebar fixes rust-lang#142147 also affects associated fns. main improvments are to pointer and box docs. before: <img width="264" height="439" alt="image" src="https://github.com/user-attachments/assets/8347c2b8-88cb-470f-beb3-6cb377ca37f0" /> after: <img width="693" height="576" alt="image" src="https://github.com/user-attachments/assets/478d1ef5-7a1e-4024-a796-d2b0fd0f5a49" />
…bs, r=notriddle,lolbinarycat [rustdoc] Add tabs to settings popover Fixes rust-lang#137050. Looks like this: <img width="497" height="370" alt="Screenshot From 2026-09-23 18-48-19" src="https://github.com/user-attachments/assets/194f4764-ceb2-4553-a60b-1166b60a238e" /> <img width="951" height="430" alt="Screenshot From 2026-09-23 18-48-33" src="https://github.com/user-attachments/assets/d336952c-0aae-44a9-967e-95b9a482e727" /> Can be tested [here](https://guillaume-gomez.fr/rustdoc/settings-popover-tabs/foo/index.html). `tests/rustdoc-gui` changes are because we now have tabs in the settings menu. So the new feature is tested without adding a new test, yeay. =D r? @notriddle
…nic, r=GuillaumeGomez Test the interaction between `--remap-path-prefix` and doctests This PR adds a run-make test to test the interaction between `--remap-path-prefix` and doctests. Related to rust-lang#163895 (comment)
…cope-of-object, r=GuillaumeGomez Make the `documentation` scope a sub-scope of the `object` scope ~~First commit from rust-lang#164278.~~ This PR moves the `documentation` scope to be a sub-scope of the `object` scope. The `object` scope is currently defined to be: "This ensures all paths in compiled executables, libraries and objects outputs are remapped but not elsewhere", which can be translated to mean everything written to disk by `rustc` it-self. It is therefore a natural extension for the `documentation` scope to be a sub-scope of it, like `macro`, `debuginfo` and `coverage`, since we use it for things written down on disk, like rustdoc-json (with rust-lang#164278 at-least) or the source code viewer.
…ue-164180, r=khyperia Fix check with `is_impl_trait_in_trait()` before expecting local id Fix an ICE when implementing a const generic method with return position `impl Trait` from another crate `RPITIT` r? khyperia fixes rust-lang#164180
…tion, r=ChrisDenton Fix(lib/sys): Restore Win7 compilation Fixes rust-lang#164340. 9c1eb80 broke the compilation of all the Windows 7 targets. The mistake is trivial though: a `cfg` attribute remnant. Indeed, the `is_console` function internally handles the Win7 case already, so is effectively always available. This therefore removes the extraneous attribute in order to fix the Win7 compilation. Another small issue introduced by the same commit are some warnings about `MaybeUninit` and other C constants being unused in the modules modified here. This is also a trivial oversight: it is now only used under non-Win7 targets. This therefore fixes that by gating the import and the definitions adequately. @rustbot label O-windows-7 C-bug T-libs
JonathanBrouwer
force-pushed
the
rollup-Y7lkZPw
branch
from
October 15, 2026 21:01
2896076 to
3083083
Compare
rustbot
added
A-run-make
rustbot
added
T-compiler
Member
Author
|
@bors r+ p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
Author
|
@bors p=11 |
Member
Author
|
Trying commonly failed jobs |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 15, 2026
Rollup of 8 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 15, 2026
…uwer Rollup of 8 pull requests Successful merges: - #164271 (Add release notes for 1.99.1) - #164361 (delegation: map return even if there is no target expression) - #162778 (rustdoc: add disambiguators for identically named method in sidebar) - #163224 ([rustdoc] Add tabs to settings popover) - #164220 (Test the interaction between `--remap-path-prefix` and doctests) - #164279 (Make the `documentation` scope a sub-scope of the `object` scope) - #164318 (Fix check with `is_impl_trait_in_trait()` before expecting local id) - #164360 (Fix(lib/sys): Restore Win7 compilation)
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for 0ea0ba4 failed: CI. Failed jobs:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 869400c failed: CI. Failed job:
|
rust-bors
Bot
added
the
S-waiting-on-author
rust-bors
Bot
removed
the
S-waiting-on-review
Contributor
|
PR #164279, which is a member of this rollup, was unapproved. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
--remap-path-prefixand doctests #164220 (Test the interaction between--remap-path-prefixand doctests)documentationscope a sub-scope of theobjectscope #164279 (Make thedocumentationscope a sub-scope of theobjectscope)is_impl_trait_in_trait()before expecting local id #164318 (Fix check withis_impl_trait_in_trait()before expecting local id)r? @ghost
Create a similar rollup