Skip to content

Declare SyntaxContext through rustc_index::newtype_index! - #164425

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:make-syntax-context-index
Oct 23, 2026
Merged

Declare SyntaxContext through rustc_index::newtype_index!#164425
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:make-syntax-context-index

Conversation

@aerooneqq

@aerooneqq aerooneqq commented Oct 16, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

SyntaxContext is basically an index type but it is not declared through newtype_index.

r? @petrochenkov

@rustbot

rustbot commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in coverage instrumentation.

cc @Zalathar

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 16, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed Oct 16, 2026
View reviewed changes
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2026
@aerooneqq
aerooneqq force-pushed the make-syntax-context-index branch from ce1f806 to 6476b1a Compare October 19, 2026 13:46
petrochenkov
petrochenkov reviewed Oct 19, 2026
View reviewed changes
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2026
@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@petrochenkov

petrochenkov commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

#163668 has been merged, unblocking.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 21, 2026
@rustbot

rustbot commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@aerooneqq
aerooneqq force-pushed the make-syntax-context-index branch from 912364a to 5615b80 Compare October 21, 2026 13:50
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2026
@aerooneqq aerooneqq mentioned this pull request Oct 21, 2026
Merged
petrochenkov
petrochenkov reviewed Oct 21, 2026
View reviewed changes
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
Comment thread compiler/rustc_span/src/hygiene.rs
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
@petrochenkov

petrochenkov commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Blocked on #164696.
@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#164696 - aerooneqq:default-for-newtype-inde…
0e758be 
…x, r=petrochenkov

Add `#[default]` for `newtype_index!`

Add `#[default]` for `newtype_index!`.

We can merge it before or after rust-lang#164425.

r? @petrochenkov
rust-bors Bot pushed a commit that referenced this pull request Oct 21, 2026
@bors
Unrolled build for #164696 in rollup 164708
e33438e 
Rollup merge of #164696 - aerooneqq:default-for-newtype-index, r=petrochenkov

Add `#[default]` for `newtype_index!`

Add `#[default]` for `newtype_index!`.

We can merge it before or after #164425.

r? @petrochenkov
@rust-bors

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqq force-pushed the make-syntax-context-index branch from 61bd549 to 13bc1d1 Compare October 22, 2026 08:52
@rustbot

rustbot commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@aerooneqq

aerooneqq commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 22, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed Oct 22, 2026
View reviewed changes
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
@petrochenkov

petrochenkov commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

r=me after addressing #164425 (comment) and squashing commits.
@rustbot author
@bors delegate+

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2026
@rust-bors

rust-bors Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

✌️ @aerooneqq, you can now approve this pull request!

If @petrochenkov told you to "r=me" after making some further change, then please make that change and post @bors r=petrochenkov.

View changes since this delegation.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 22, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aerooneqq

aerooneqq commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=petrochenkov squash msg="Declare SyntaxContext through rustc_index::newtype_index!"

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

🔨 14 commits were squashed into 63e2ea2.

@rust-bors
rust-bors Bot force-pushed the make-syntax-context-index branch from f41d0c4 to 63e2ea2 Compare October 22, 2026 12:27
@rust-bors

rust-bors Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 63e2ea2 has been tentatively approved by petrochenkov

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 22, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 22, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 22, 2026
@bors
Auto merge of #164757 - JonathanBrouwer:rollup-QMS3ewH, r=JonathanBro…
b8fa1fb 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing)
 - #161790 (update to illumos sysroot 20210501)
 - #163087 (rmake: Add helpers for iterating symbols and objects)
 - #163586 (refactor Windows remove_dir_all)
 - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`)
 - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`)
 - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`)
 - #156841 (Avoid cloning CFG-related analysis data.)
 - #164654 (Add reference annotations for unions)
 - #164717 (Allow `llm-assisted` label to be set without write access)
 - #164735 (Remove docs mentioning instability of wasm64)
 - #164737 (Update LLVM PassBuilder constructor calls to pass a context)

Failed merges:

 - #164636 (Remove `record_*` macros from the metadata encoder)
rust-bors Bot pushed a commit that referenced this pull request Oct 23, 2026
@bors
Auto merge of #164757 - JonathanBrouwer:rollup-QMS3ewH, r=JonathanBro…
eb022b1 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing)
 - #161790 (update to illumos sysroot 20210501)
 - #163087 (rmake: Add helpers for iterating symbols and objects)
 - #163586 (refactor Windows remove_dir_all)
 - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`)
 - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`)
 - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`)
 - #156841 (Avoid cloning CFG-related analysis data.)
 - #164654 (Add reference annotations for unions)
 - #164717 (Allow `llm-assisted` label to be set without write access)
 - #164735 (Remove docs mentioning instability of wasm64)
 - #164737 (Update LLVM PassBuilder constructor calls to pass a context)

Failed merges:

 - #164636 (Remove `record_*` macros from the metadata encoder)
rust-bors Bot pushed a commit that referenced this pull request Oct 23, 2026
@bors
Auto merge of #164757 - JonathanBrouwer:rollup-QMS3ewH, r=JonathanBro…
0cefa27 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing)
 - #161790 (update to illumos sysroot 20210501)
 - #163087 (rmake: Add helpers for iterating symbols and objects)
 - #163586 (refactor Windows remove_dir_all)
 - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`)
 - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`)
 - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`)
 - #156841 (Avoid cloning CFG-related analysis data.)
 - #164654 (Add reference annotations for unions)
 - #164717 (Allow `llm-assisted` label to be set without write access)
 - #164735 (Remove docs mentioning instability of wasm64)
 - #164737 (Update LLVM PassBuilder constructor calls to pass a context)

Failed merges:

 - #164636 (Remove `record_*` macros from the metadata encoder)
@rust-bors
rust-bors Bot merged commit cd7a7c6 into rust-lang:main Oct 23, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 23, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 23, 2026
@bors
Unrolled build for #164425 in rollup 164757
58a325d 
Rollup merge of #164425 - aerooneqq:make-syntax-context-index, r=petrochenkov

Declare `SyntaxContext` through `rustc_index::newtype_index!`

`SyntaxContext` is basically an index type but it is not declared through `newtype_index`.

r? @petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments
@Zalathar Zalathar Zalathar left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

5 participants

@aerooneqq @rustbot @rust-log-analyzer @petrochenkov @Zalathar