Rollup of 12 pull requests by JonathanBrouwer · Pull Request #164757 · rust-lang/rust

JonathanBrouwer · 2026-10-22T18:08:34Z

View all comments

Successful merges:

Avoid stdlib's impl Hash for Path for stable hashing #164458 (Avoid stdlib's impl Hash for Path for stable hashing)
update to illumos sysroot 20210501 #161790 (update to illumos sysroot 20210501)
rmake: Add helpers for iterating symbols and objects #163087 (rmake: Add helpers for iterating symbols and objects)
refactor Windows remove_dir_all #163586 (refactor Windows remove_dir_all)
std: use SOCK_NONBLOCK in connect_timeout #163983 (std: use SOCK_NONBLOCK in connect_timeout)
Rename PostTypeckUntilBorrowck -> PostTypeckThroughBorrowck #164307 (Rename PostTypeckUntilBorrowck -> PostTypeckThroughBorrowck)
Declare SyntaxContext through rustc_index::newtype_index! #164425 (Declare SyntaxContext through rustc_index::newtype_index!)
Avoid cloning CFG-related analysis data. #156841 (Avoid cloning CFG-related analysis data.)
Add reference annotations for unions #164654 (Add reference annotations for unions)
Allow llm-assisted label to be set without write access #164717 (Allow llm-assisted label to be set without write access)
Remove docs mentioning instability of wasm64 #164735 (Remove docs mentioning instability of wasm64)
Update LLVM PassBuilder constructor calls to pass a context #164737 (Update LLVM PassBuilder constructor calls to pass a context)

Failed merges:

Remove record_* macros from the metadata encoder #164636 (Remove record_* macros from the metadata encoder)

r? @ghost

Create a similar rollup

Let's link the relevant UI tests to the Reference's rules for unions.

and update plaform note get illumos sysroot from mirror

…access

This module can contain various helpers for `object`, not strictly those that work with symbols.

Memory64 is merged into the spec since 2025-07-23 (WASM 3.0).

This will make it possible to remove the compiler's Hash impl for FileName.

A subtle consequence of the stage0 redesign is that the compiler must take care to avoid relying on any stdlib-provided Hash impl when computing stable hashes, or at least any such impl that is actually liable to change. This was noticed when trying to strengthen the provided Hash impl for Path, which triggered baffling CI failures because the stable hashes produced by the stage1 compiler (built against stage0 stdlib) were inconsistent with the ones that would have been produced by the stage2 compiler (built against in-tree stdlib). This PR aims to unblock changes to `impl Hash for Path`, by making the compiler not rely on it for stable hashing. It does not attempt to solve the broader problem of the compiler relying on stdlib hash details.

Avoid stdlib's `impl Hash for Path` for stable hashing A subtle consequence of the stage0 redesign is that the compiler must take care to avoid relying on any stdlib-provided Hash impl when computing stable hashes, or at least any such impl that is actually liable to change. This was noticed when trying to strengthen the provided Hash impl for Path, which triggered baffling CI failures because the stable hashes produced by the stage1 compiler (built against stage0 stdlib) were inconsistent with the ones that would have been produced by the stage2 compiler (built against in-tree stdlib). This PR aims to unblock changes to `impl Hash for Path`, by making the compiler not rely on it for stable hashing. It does not attempt to solve the broader problem of the compiler relying on stdlib hash details.

update to illumos sysroot 20210501 Update the sysroot for illumos to this one: https://github.com/illumos/sysroot/releases/#release-20210501-e0b4275f34-v0 Closes rust-lang#150756

rmake: Add helpers for iterating symbols and objects We have a handful tests that do a common pattern of opening a file, looping through its symbols, and performing some validation on each one, which can be a bit inconvenient to do manually. The pattern at https://github.com/rust-lang/compiler-builtins/blob/f521807de24520770991263387ba8c06e462edf8/crates/symcheck/src/main.rs works rather well to make this easier, so add it at `rmake` and update one test that does symbol iteration.

@ChrisDenton

…isDenton refactor Windows remove_dir_all It took me a bit to understand this code. I hope I understood it correctly now. r? @ChrisDenton

…hnTitor std: use `SOCK_NONBLOCK` in `connect_timeout` I doubt the performance improvement will be measurable, but using [`SOCK_NONBLOCK`](https://manned.org/man/socket) upon socket creation instead of manually setting the non-blocking mode seemed like a good idea to me. Implementing this required a consolidation of the `connect_timeout` logic, which seems like a good thing in its own right.

…Borrowck-rename, r=jdonszelmann Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck` This was a rename suggested in the following [Zulip thread](https://rust-lang.zulipchat.com/#narrow/channel/618216-t-types.2Fcall-for-participation/topic/rename.20.60TypingMode.3A.3APostTypeckThroughBorrowck.60/with/624384207) r? jdonszelmann

@petrochenkov

…x, r=petrochenkov Declare `SyntaxContext` through `rustc_index::newtype_index!` `SyntaxContext` is basically an index type but it is not declared through `newtype_index`. r? @petrochenkov

Avoid cloning CFG-related analysis data. For perf. We can avoid cloning CFG-related data while mutating the body.

…ations_unions, r=PLeVasseur,traviscross Add reference annotations for unions Let's link the relevant UI tests to the Reference's rules for unions.

Allow `llm-assisted` label to be set without write access I.e. allow contributors to set https://github.com/rust-lang/rust/labels/llm-assisted via triagebot as well.

@alexcrichton

Remove docs mentioning instability of wasm64 Memory64 is merged into the spec, from my reading since 2025-07-23 (and included as part of WebAssembly 3.0). (It still isn't available in Safari and some other engines, but we shouldn't track that in our docs, see https://webassembly.org/features/ for that instead). r? compiler CC target maintainer @alexcrichton

Update LLVM PassBuilder constructor calls to pass a context LLVM's llvm/llvm-project#233150 made the PassBuilder constructor take a LLVMContext argument.

rust-bors · 2026-10-23T03:10:07Z

☀️ Try build successful (CI)
Build commit: 427cbba (427cbbaaf88d0bfe763a91413e90c4ee2d6d9bb1)
Base parent: 7189d39 (7189d39d9ce936881b8132c6addeaf3e295cd455)

rust-bors · 2026-10-23T04:08:51Z

💔 Test for eb022b1 failed: CI. Failed job:

auto - dist-x86_64-msvc (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-10-23T04:08:53Z

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

jhpratt · 2026-10-23T04:14:58Z

Seems spurious…again.

@bors retry

rust-bors · 2026-10-23T07:30:42Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 14m 58s
Pushing 0cefa27 to main...

github-actions · 2026-10-23T07:33:51Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7189d39 (parent) -> 0cefa27 (this PR)

Test differences

Show 24 test diffs

Stage 0

stable_hash::tests::empty_path_rebracketing: [missing] -> pass (J1)
stable_hash::tests::path_component_rebracketing: [missing] -> pass (J1)

Stage 1

stable_hash::tests::empty_path_rebracketing: [missing] -> pass (J2)
stable_hash::tests::path_component_rebracketing: [missing] -> pass (J2)

Stage 2

[run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)

Additionally, 19 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0cefa27fe3deee26fc98ee44249406358d9f0d26 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-pr-check-1: 57m 40s -> 22m 58s (-60.2%)
test-x86_64-gnu-llvm-22-1: 49m 53s -> 1h 19m (+59.0%)
dist-x86_64-msvc-alt: 1h 51m -> 2h 56m (+57.5%)
test-x86_64-gnu-gcc-core-tests: 24m 9s -> 12m 1s (-50.2%)
dist-x86_64-illumos: 2h 5m -> 1h 11m (-43.0%)
test-x86_64-gnu-stdlib-semver-check: 18m 27s -> 10m 33s (-42.8%)
dist-x86_64-mingw: 2h 55m -> 1h 41m (-42.1%)
dist-loongarch64-linux: 1h 28m -> 2h 2m (+38.9%)
dist-arm-linux-gnueabi: 1h 8m -> 1h 35m (+38.7%)
test-i686-gnu-2: 1h 37m -> 1h 1m (-37.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-10-23T08:21:28Z

Finished benchmarking commit (0cefa27): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.3%, 0.5%]	7
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	3
Improvements ✅ (secondary)	-0.4%	[-0.7%, -0.2%]	14
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	3

Max RSS (memory usage)

Results (primary -0.4%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.4%, 2.3%]	6
Regressions ❌ (secondary)	1.5%	[0.6%, 4.8%]	5
Improvements ✅ (primary)	-1.5%	[-3.6%, -0.5%]	6
Improvements ✅ (secondary)	-1.9%	[-5.4%, -0.4%]	4
All ❌✅ (primary)	-0.4%	[-3.6%, 2.3%]	12

Cycles

Results (primary 0.1%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.4%, 2.2%]	7
Regressions ❌ (secondary)	1.4%	[0.5%, 3.3%]	7
Improvements ✅ (primary)	-0.6%	[-1.1%, -0.4%]	8
Improvements ✅ (secondary)	-1.1%	[-2.2%, -0.5%]	4
All ❌✅ (primary)	0.1%	[-1.1%, 2.2%]	15

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 486.294s -> 487.555s (0.26%)
Artifact size: 406.54 MiB -> 406.51 MiB (-0.01%)

rust-bors · 2026-10-23T08:36:56Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#164458	Avoid stdlib's `impl Hash for Path` for stable hashing	`58d0037a71bed4646edfe2fdd0267b745f5ebc41` (link)
#161790	update to illumos sysroot 20210501	`8866e852b2e0fb600a2aa0a1cde59158fd5e8e68` (link)
#163087	rmake: Add helpers for iterating symbols and objects	`e830d4308a447b56e66dcc774886fce82370b929` (link)
#163586	refactor Windows remove_dir_all	`cffb528193f9f6a6b353c2cd4d77710cdad7b232` (link)
#163983	std: use `SOCK_NONBLOCK` in `connect_timeout`	`f0692c966c1615974b9ecafbd54ece7d0278c1de` (link)
#164307	Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorro…	`e69fad2da62c61303394216e6feff59a250339fd` (link)
#164425	Declare `SyntaxContext` through `rustc_index::newtype_index…	`58a325d8ce58971371199b09a55ae1428cfee846` (link)
#156841	Avoid cloning CFG-related analysis data.	`ced830a340434226604792fb4d7f6abd8a1c8f33` (link)
#164654	Add reference annotations for unions	`a605b15bfaab0b2d769b6eb86faae64bfa171fe8` (link)
#164717	Allow `llm-assisted` label to be set without write access	`c913f2cc8f8296946146a5dad2d5ff45bf69547f` (link)
#164735	Remove docs mentioning instability of wasm64	`00141e3e275a2b73e259965110a0e69642ba0e2f` (link)
#164737	Update LLVM PassBuilder constructor calls to pass a context	`e8146b003a6ed64898ffed5f5185819f75b0d1af` (link)

parent commit: 7189d39d9c

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

JonathanBrouwer · 2026-10-23T08:40:08Z

@rust-timer triage all

rust-timer · 2026-10-23T08:40:13Z

Running triage with 6 benchmarks

Triage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
For this rollup, these benchmarks are:

ctfe-stress-5
deep-vector
issue-58319
large-workspace
libc-0.2.172
tt-muncher

#164458 `58d0037` Avoid stdlib's `impl Hash for Path` for stable hashing

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.3%, 0.5%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.1%, -0.0%]	4

#161790 `8866e85` update to illumos sysroot 20210501

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#163087 `e830d43` rmake: Add helpers for iterating symbols and objects

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary 4.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.9%	[4.9%, 4.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#163586 `cffb528` refactor Windows remove_dir_all

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.6%	[-1.6%, -1.6%]	1
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#163983 `f0692c9` std: use `SOCK_NONBLOCK` in `connect_timeout`

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.8%	[4.8%, 4.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-1.9%, -1.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#164307 `e69fad2` Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#164425 `58a325d` Declare `SyntaxContext` through `rustc_index::newtype_index!`

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	2
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	3
Improvements ✅ (secondary)	-0.4%	[-0.7%, -0.3%]	15
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	3

Max RSS (memory usage)

Results (secondary -5.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.8%	[-5.8%, -5.8%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -15.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-15.5%	[-15.5%, -15.5%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

#156841 `ced830a` Avoid cloning CFG-related analysis data.

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#164654 `a605b15` Add reference annotations for unions

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-8.4%, -1.0%]	6
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[2.9%, 5.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

#164717 `c913f2c` Allow `llm-assisted` label to be set without write access

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#164735 `00141e3` Remove docs mentioning instability of wasm64

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.4%, -1.7%]	2
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#164737 `e8146b0` Update LLVM PassBuilder constructor calls to pass a context

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

RalfJung and others added 30 commits October 1, 2026 08:15

add some comments to Windows remove_dir_all

ba96988

avoid re-reading the same dir entries over and over

e90fd2c

std: use SOCK_NONBLOCK in connect_timeout

dff7a20

Rename PostTypeckUntilBorrowck -> PostTypeckThroughBorrowck

2cf8532

Remove -Z option

71ee80a

Add reference annotations for unions

205d6ac

Let's link the relevant UI tests to the Reference's rules for unions.

update to illumos sysroot 20210501

2eef187

and update plaform note get illumos sysroot from mirror

chore(triagebot): allow llm-assisted label to be set without write …

0f64fe6

…access

rmake: Rename the symbols to obj

88898fe

This module can contain various helpers for `object`, not strictly those that work with symbols.

rmake: Add helpers for iterating symbols and objects

2dc48e7

Remove docs mentioning instability of wasm64

01844ed

Memory64 is merged into the spec since 2025-07-23 (WASM 3.0).

update PassBuilder constructor calls

92e885a

Avoid cloning CFG-related analysis data.

222c583

use a default LLVMContext in LLVMRustPrintPasses

31d8b41

clippy: Avoid hashing FileName

e642769

This will make it possible to remove the compiler's Hash impl for FileName.

Sort impl_dep_tracking_hash_via_hash!

9a82d1a

Declare through

63e2ea2

Rollup merge of rust-lang#161790 - gwr:gwr2, r=tgross35

57dc51e

update to illumos sysroot 20210501 Update the sysroot for illumos to this one: https://github.com/illumos/sysroot/releases/#release-20210501-e0b4275f34-v0 Closes rust-lang#150756

Rollup merge of rust-lang#163586 - RalfJung:win-remove-dir-all, r=Chr…

02eac2f

…isDenton refactor Windows remove_dir_all It took me a bit to understand this code. I hope I understood it correctly now. r? @ChrisDenton

Rollup merge of rust-lang#164425 - aerooneqq:make-syntax-context-inde…

cd7a7c6

…x, r=petrochenkov Declare `SyntaxContext` through `rustc_index::newtype_index!` `SyntaxContext` is basically an index type but it is not declared through `newtype_index`. r? @petrochenkov

Rollup merge of rust-lang#156841 - dianqk:avoid-clone, r=mu001999

9b007cb

Avoid cloning CFG-related analysis data. For perf. We can avoid cloning CFG-related data while mutating the body.

Rollup merge of rust-lang#164654 - traviscross:TC/add-reference-annot…

209922e

…ations_unions, r=PLeVasseur,traviscross Add reference annotations for unions Let's link the relevant UI tests to the Reference's rules for unions.

Rollup merge of rust-lang#164717 - jieyouxu:jieyouxu/label, r=lqd

90a6197

Allow `llm-assisted` label to be set without write access I.e. allow contributors to set https://github.com/rust-lang/rust/labels/llm-assisted via triagebot as well.

Rollup merge of rust-lang#164737 - zmodem:passbuilder, r=nikic

dce705a

Update LLVM PassBuilder constructor calls to pass a context LLVM's llvm/llvm-project#233150 made the PassBuilder constructor take a LLVMContext argument.

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 23, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Oct 23, 2026

Rollup of 6 pull requests #164779

Closed

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 23, 2026

rust-bors Bot merged commit 0cefa27 into rust-lang:main Oct 23, 2026
16 checks passed

rustbot added this to the 1.101.0 milestone Oct 23, 2026

rustbot added the perf-regression Performance regression. label Oct 23, 2026

Conversation

JonathanBrouwer commented Oct 22, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Oct 23, 2026

Uh oh!

rust-bors Bot commented Oct 23, 2026

Uh oh!

rust-log-analyzer commented Oct 23, 2026

Uh oh!

jhpratt commented Oct 23, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 23, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 23, 2026

Overall result: ❌✅ regressions and improvements - please read:

Uh oh!

rust-bors Bot commented Oct 23, 2026

Uh oh!

JonathanBrouwer commented Oct 23, 2026

Uh oh!

rust-timer commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

#164458 58d0037 Avoid stdlib's impl Hash for Path for stable hashing

#161790 8866e85 update to illumos sysroot 20210501

#163087 e830d43 rmake: Add helpers for iterating symbols and objects

#163586 cffb528 refactor Windows remove_dir_all

#163983 f0692c9 std: use SOCK_NONBLOCK in connect_timeout

#164307 e69fad2 Rename PostTypeckUntilBorrowck -> PostTypeckThroughBorrowck

#164425 58a325d Declare SyntaxContext through rustc_index::newtype_index!

#156841 ced830a Avoid cloning CFG-related analysis data.

#164654 a605b15 Add reference annotations for unions

#164717 c913f2c Allow llm-assisted label to be set without write access

#164735 00141e3 Remove docs mentioning instability of wasm64

#164737 e8146b0 Update LLVM PassBuilder constructor calls to pass a context

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

JonathanBrouwer commented Oct 22, 2026 •

edited by rustbot

Loading

rust-timer commented Oct 23, 2026 •

edited

Loading

#164458 `58d0037` Avoid stdlib's `impl Hash for Path` for stable hashing

#161790 `8866e85` update to illumos sysroot 20210501

#163087 `e830d43` rmake: Add helpers for iterating symbols and objects

#163586 `cffb528` refactor Windows remove_dir_all

#163983 `f0692c9` std: use `SOCK_NONBLOCK` in `connect_timeout`

#164307 `e69fad2` Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`

#164425 `58a325d` Declare `SyntaxContext` through `rustc_index::newtype_index!`

#156841 `ced830a` Avoid cloning CFG-related analysis data.

#164654 `a605b15` Add reference annotations for unions

#164717 `c913f2c` Allow `llm-assisted` label to be set without write access

#164735 `00141e3` Remove docs mentioning instability of wasm64

#164737 `e8146b0` Update LLVM PassBuilder constructor calls to pass a context