Remove `record_*` macros from the metadata encoder by susitsm · Pull Request #164636 · rust-lang/rust

susitsm · 2026-10-20T13:06:27Z

Replaces record_* macros (record_some_lazy, record_some, record_value, record_array, record_defaulted_array) with encoder.table_writer().field(index, value) in the metadata encoder

@Zalathar for visibility

rustbot · 2026-10-20T13:06:33Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 77 candidates
Random selection from 19 candidates

susitsm · 2026-10-21T07:32:38Z

The job failed because of a network error when connecting to crates.io. Can I restart it somehow?

Zalathar · 2026-10-21T11:25:39Z

r? me

cc @aerooneqq (author of #162900) to check that this isn’t going to cause unexpected problems for anything you have planned.

aerooneqq · 2026-10-21T11:37:36Z

cc @aerooneqq (author of #162900) to check that this isn’t going to cause unexpected problems for anything you have planned.

Thanks, we already merged everything we planned after #162900, so it won't cause any problems.

Zalathar · 2026-10-21T13:51:53Z

@bors try @rust-timer queue

…<try> Remove `record_*` macros from the metadata encoder

rust-bors · 2026-10-21T14:55:10Z

☀️ Try build successful (CI)
Build commit: 706d2ca (706d2ca7a7d54e00031e0bdfe538dde4e1148330)
Base parent: 1731fae (1731faea0da5b4ebf881d8e53f98066c17a74711)

rust-timer · 2026-10-21T16:35:59Z

Finished benchmarking commit (706d2ca): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[0.5%, 8.0%]	4
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-3.0%	[-4.9%, -0.6%]	4
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Cycles

Results (secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[1.2%, 3.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-2.1%, -0.6%]	7
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.972s -> 495.97s (1.02%)
Artifact size: 406.53 MiB -> 406.46 MiB (-0.02%)

…-macros, r=Zalathar Remove `record_*` macros from the metadata encoder Replaces `record_*` macros (`record_some_lazy`, `record_some`, `record_value`, `record_array`, `record_defaulted_array`) with `encoder.table_writer().field(index, value)` in the metadata encoder

…uwer Rollup of 5 pull requests Successful merges: - #161790 (update to illumos sysroot 20210501) - #163087 (rmake: Add helpers for iterating symbols and objects) - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`) - #164636 (Remove `record_*` macros from the metadata encoder) - #164717 (Allow `llm-assisted` label to be set without write access)

…uwer Rollup of 12 pull requests Successful merges: - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing) - #161790 (update to illumos sysroot 20210501) - #163087 (rmake: Add helpers for iterating symbols and objects) - #163586 (refactor Windows remove_dir_all) - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`) - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`) - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`) - #156841 (Avoid cloning CFG-related analysis data.) - #164654 (Add reference annotations for unions) - #164717 (Allow `llm-assisted` label to be set without write access) - #164735 (Remove docs mentioning instability of wasm64) - #164737 (Update LLVM PassBuilder constructor calls to pass a context) Failed merges: - #164636 (Remove `record_*` macros from the metadata encoder)

…-macros, r=Zalathar Remove `record_*` macros from the metadata encoder Replaces `record_*` macros (`record_some_lazy`, `record_some`, `record_value`, `record_array`, `record_defaulted_array`) with `encoder.table_writer().field(index, value)` in the metadata encoder

…uwer Rollup of 12 pull requests Successful merges: - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing) - #161790 (update to illumos sysroot 20210501) - #163087 (rmake: Add helpers for iterating symbols and objects) - #163586 (refactor Windows remove_dir_all) - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`) - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`) - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`) - #156841 (Avoid cloning CFG-related analysis data.) - #164654 (Add reference annotations for unions) - #164717 (Allow `llm-assisted` label to be set without write access) - #164735 (Remove docs mentioning instability of wasm64) - #164737 (Update LLVM PassBuilder constructor calls to pass a context) Failed merges: - #164636 (Remove `record_*` macros from the metadata encoder)

…-macros, r=Zalathar Remove `record_*` macros from the metadata encoder Replaces `record_*` macros (`record_some_lazy`, `record_some`, `record_value`, `record_array`, `record_defaulted_array`) with `encoder.table_writer().field(index, value)` in the metadata encoder

…ns using the `EncodeFrom` trait

rustbot · 2026-10-23T08:20:39Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Zalathar · 2026-10-23T08:30:59Z

@bors r+

rust-bors · 2026-10-23T08:31:03Z

📌 Commit 10dcc9b has been tentatively approved by Zalathar

It will be put into the queue for this repository once PR CI succeeds.

…uwer Rollup of 5 pull requests Successful merges: - #162395 (Make more float intrinsics generic) - #164636 (Remove `record_*` macros from the metadata encoder) - #164624 (make `RustaceansAreAwesome` satisfy projection clauses) - #164695 ([tiny] Include trait definition line when pointing at assoc function in E0308) - #164744 (some `Attribute`/`AttributeExt` cleanups)

Rollup merge of #164636 - susitsm:rmeta-encode-remove-record-macros, r=Zalathar Remove `record_*` macros from the metadata encoder Replaces `record_*` macros (`record_some_lazy`, `record_some`, `record_value`, `record_array`, `record_defaulted_array`) with `encoder.table_writer().field(index, value)` in the metadata encoder

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 20, 2026

rustbot assigned fee1-dead Oct 20, 2026

Zalathar reviewed Oct 21, 2026

View reviewed changes

Comment thread compiler/rustc_metadata/src/rmeta/mod.rs Outdated

Zalathar reviewed Oct 21, 2026

View reviewed changes

Comment thread compiler/rustc_metadata/src/rmeta/encoder.rs

susitsm force-pushed the rmeta-encode-remove-record-macros branch 2 times, most recently from 8b81977 to 61df381 Compare October 21, 2026 06:44

This comment has been minimized.

Sign in to view

susitsm force-pushed the rmeta-encode-remove-record-macros branch from 61df381 to b54b9ae Compare October 21, 2026 08:20

This comment has been minimized.

Sign in to view

Zalathar reviewed Oct 21, 2026

View reviewed changes

Comment thread compiler/rustc_metadata/src/rmeta/mod.rs Outdated

Zalathar reviewed Oct 21, 2026

View reviewed changes

Comment thread compiler/rustc_metadata/src/rmeta/parameterized.rs

Zalathar reviewed Oct 21, 2026

View reviewed changes

Comment thread compiler/rustc_metadata/src/rmeta/parameterized.rs Outdated

susitsm force-pushed the rmeta-encode-remove-record-macros branch from b54b9ae to e84dee3 Compare October 21, 2026 10:58

rustbot assigned Zalathar and unassigned fee1-dead Oct 21, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 21, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 21, 2026

Auto merge of #164636 - susitsm:rmeta-encode-remove-record-macros, r=…

706d2ca

…<try> Remove `record_*` macros from the metadata encoder

Zalathar reviewed Oct 21, 2026

View reviewed changes

Comment thread compiler/rustc_metadata/src/rmeta/encoder.rs

This comment has been minimized.

Sign in to view

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2026

JonathanBrouwer mentioned this pull request Oct 22, 2026

Rollup of 5 pull requests #164742

Closed

JonathanBrouwer mentioned this pull request Oct 22, 2026

Rollup of 12 pull requests #164757

Merged

jhpratt mentioned this pull request Oct 22, 2026

Rollup of 5 pull requests #164773

Closed

JonathanBrouwer mentioned this pull request Oct 23, 2026

Rollup of 6 pull requests #164779

Closed

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 23, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 23, 2026

susitsm added 4 commits October 23, 2026 10:18

remove unused live_args_for_alias_from_outlives_bounds from metadata

37adec2

rmeta: move opt_rpitit_info from defaulted to optional

77d8722

use tcx instead of self.tcx when available

2e73b1d

Replace record_* macros in the metadata encoder with setter functio…

10dcc9b

…ns using the `EncodeFrom` trait

susitsm force-pushed the rmeta-encode-remove-record-macros branch from e84dee3 to 10dcc9b Compare October 23, 2026 08:20

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2026

JonathanBrouwer mentioned this pull request Oct 23, 2026

Rollup of 5 pull requests #164788

Merged

rust-bors Bot merged commit b12a9ee into rust-lang:main Oct 23, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 23, 2026

Conversation

susitsm commented Oct 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 20, 2026

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

susitsm commented Oct 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Zalathar commented Oct 21, 2026

Uh oh!

aerooneqq commented Oct 21, 2026

Uh oh!

Zalathar commented Oct 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

rust-bors Bot commented Oct 21, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Oct 21, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

This comment has been minimized.

rustbot commented Oct 23, 2026

Uh oh!

Zalathar commented Oct 23, 2026

Uh oh!

rust-bors Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

susitsm commented Oct 20, 2026 •

edited by rustbot

Loading