Repository navigation
Rollup of 4 perf-sensitive pull requests - #164921
Closed
JonathanBrouwer wants to merge 12 commits into
Closed
JonathanBrouwer wants to merge 12 commits into
JonathanBrouwer wants to merge 12 commits into
Conversation
This avoids needing the overhead of a call before discovering that the `Cow` is already owned.
These show up in hot paths, and inlining should allow optimizing them.
These are simple wrappers but nonetheless don't get inlined and show up in hot paths.
These are simple wrappers.
…Simulacrum Add various `#[inline]` annotations for simple functions on hot paths that don't get inlined All of these are simple, likely to be optimizable once inlined into their caller, and found on hot paths in profiles (I used `clap_derive` for the profiling) as non-inlined functions.
…=hanna-kruppe Don't emit allow attributes in try/contract desugaring
…rouwer,nnethercote create fast path for attributes created in builtin macro expansions Emitting attributes in rustc_builtin_macros involves creating an `ast::Attribute` and token trees, just to parse that into a parsed attribute almost immediately. This PR sidesteps that by creating a new `ast::Attribute` variant that does not do this. I've taken care to only do this for the derive and test macros, so that they never re-enter the parser. This results in some moderate performance gains. It'll also take away almost all of the regressions in rust-lang#164217 (comment) (see rust-lang#164281 (comment) for a perf run of this and that PR stacked) r? @nnethercote
…r=beetrees Deduplicate DefId encodings in the query cache I used a similar approach for DefId encoding and decoding, based on the existing Symbol encoder and decoder. https://github.com/rust-lang/rust/blob/81900216ce9ee0b48f2c563c696bfca98cfba755/compiler/rustc_middle/src/query/on_disk_cache.rs#L818 https://github.com/rust-lang/rust/blob/81900216ce9ee0b48f2c563c696bfca98cfba755/compiler/rustc_middle/src/query/on_disk_cache.rs#L447
rustbot
added
A-attributes
JonathanBrouwer
changed the title
Member
Author
|
@bors r+ p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
…uwer Rollup of 4 perf-sensitive pull requests Successful merges: - #163845 (Add various `#[inline]` annotations for simple functions on hot paths that don't get inlined) - #164122 (Don't emit allow attributes in try/contract desugaring) - #164260 (create fast path for attributes created in builtin macro expansions) - #164300 (Deduplicate DefId encodings in the query cache) Failed merges: - #164790 (Split `LintLevelsBuilder::add` into `add_ast` and `add_hir`)
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for d3a1613 failed: CI. Failed job:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
Member
Author
|
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
…uwer Rollup of 4 perf-sensitive pull requests Successful merges: - #163845 (Add various `#[inline]` annotations for simple functions on hot paths that don't get inlined) - #164122 (Don't emit allow attributes in try/contract desugaring) - #164260 (create fast path for attributes created in builtin macro expansions) - #164300 (Deduplicate DefId encodings in the query cache) Failed merges: - #164790 (Split `LintLevelsBuilder::add` into `add_ast` and `add_hir`)
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 1c4bf80 failed: CI. Failed job:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 25, 2026
Revert "rustc_codegen_gcc subtree update" Reverts rust-lang#164869 because it broke main again See rust-lang#164921 (comment) See discussion in [#t-infra > Tree ops @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/near/634790354)
rustbot
removed
the
S-waiting-on-review
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
Rollup merge of #164929 - JonathanBrouwer:revert-gcc, r=Kobzol Revert "rustc_codegen_gcc subtree update" Reverts #164869 because it broke main again See #164921 (comment) See discussion in [#t-infra > Tree ops @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/near/634790354)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[inline]annotations for simple functions on hot paths that don't get inlined #163845 (Add various#[inline]annotations for simple functions on hot paths that don't get inlined)Failed merges:
LintLevelsBuilder::addintoadd_astandadd_hir#164790 (SplitLintLevelsBuilder::addintoadd_astandadd_hir)r? @ghost
Create a similar rollup