Skip to content

Revert "rustc_codegen_gcc subtree update" - #164929

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:revert-gcc
Oct 25, 2026
Merged

Revert "rustc_codegen_gcc subtree update"#164929
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:revert-gcc

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Oct 25, 2026

Copy link
Copy Markdown
Member

Reverts #164869 because it broke main again

See #164921 (comment)
See discussion in #t-infra > Tree ops @ 💬

@JonathanBrouwer
Revert "Rollup merge of rust-lang#164869 - GuillaumeGomez:cg_gcc-subt…
ceeb0e0 
…ree-sync, r=GuillaumeGomez"

This reverts commit 36096d0, reversing
changes made to c1ed5e8.
@rustbot

rustbot commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2026
@rustbot

rustbot commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 19 candidates

@rustbot

rustbot commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

    If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtrees.

@Kobzol

Kobzol commented Oct 25, 2026

Copy link
Copy Markdown
Member

Thanks! Approving to unbork CI.

r? kobzol

@bors r+

@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ceeb0e0 has been tentatively approved by Kobzol

It will be put into the queue for this repository once PR CI succeeds.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 25, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2026
@JonathanBrouwer

JonathanBrouwer commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

@bors r=Kobzol force

@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ceeb0e0 has been approved by Kobzol

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 25, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
@bors
Auto merge of #164931 - JonathanBrouwer:rollup-evgAZRd, r=JonathanBro…
76456a6 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #163845 (Add various `#[inline]` annotations for simple functions on hot paths that don't get inlined)
 - #164122 (Don't emit allow attributes in try/contract desugaring)
 - #164260 (create fast path for attributes created in builtin macro expansions)
 - #164300 (Deduplicate DefId encodings in the query cache)
 - #164929 (Revert "rustc_codegen_gcc subtree update")

Failed merges:

 - #164790 (Split `LintLevelsBuilder::add` into `add_ast` and `add_hir`)
@hanna-kruppe hanna-kruppe mentioned this pull request Oct 25, 2026
Merged
@Walentalien Walentalien mentioned this pull request Oct 25, 2026
Open
@antoyo antoyo mentioned this pull request Oct 25, 2026
Open
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 25, 2026
Open
@TechnoPorg TechnoPorg mentioned this pull request Oct 25, 2026
Open
@rust-bors
rust-bors Bot merged commit 90dd286 into rust-lang:main Oct 25, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 25, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
@bors
Unrolled build for #164929 in rollup 164931
359bf16 
Rollup merge of #164929 - JonathanBrouwer:revert-gcc, r=Kobzol

Revert "rustc_codegen_gcc subtree update"

Reverts #164869 because it broke main again

See #164921 (comment)
See discussion in [#t-infra > Tree ops @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/near/634790354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kobzol Kobzol

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer @rustbot @Kobzol @jieyouxu