Rollup of 21 pull requests by JonathanBrouwer · Pull Request #165056 · rust-lang/rust

JonathanBrouwer · 2026-10-27T19:50:17Z

Successful merges:

Reject cfg on expressions that cannot be safely removed #159580 (Reject cfg on expressions that cannot be safely removed)
raise ambiguity error on attribute macro that could be tool attribute #162597 (raise ambiguity error on attribute macro that could be tool attribute)
Enable --generate-link-to-definition rustdoc option on std docs #162808 (Enable --generate-link-to-definition rustdoc option on std docs)
Recover invalid return type until {, } or ; #163059 (Recover invalid return type until {, } or ;)
Use runCodeGen Abstraction for new LLVM #163672 (Use runCodeGen Abstraction for new LLVM)
Add a future incompat warning for #[no_link] #164028 (Add a future incompat warning for #[no_link])
Suggest adding lifetime for dyn Trait in return type #164188 (Suggest adding lifetime for dyn Trait in return type)
fix: handle false in root contexts #164345 (fix: handle false in root contexts)
drop ands which are a superset of other ands #164494 (drop ands which are a superset of other ands)
delegation: emit error when there is no field for Self mapping #164785 (delegation: emit error when there is no field for Self mapping)
Don't use IntoIterator in parallel API #164799 (Don't use IntoIterator in parallel API)
Refactor call argument codegen #164871 (Refactor call argument codegen)
parse inline and rustc_force_inline with same parser #164648 (parse inline and rustc_force_inline with same parser)
fix: Prevent ICE when comparing EII impl against generic declaration #164811 (fix: Prevent ICE when comparing EII impl against generic declaration)
make tool_attrs method to retrieve tool attributes. #164900 (make tool_attrs method to retrieve tool attributes.)
copy_nonoverlapping: dont skip ovelrap check when src is fully uninit #164993 (copy_nonoverlapping: dont skip ovelrap check when src is fully uninit)
miri: add missing alignment check in write_bytes #164996 (miri: add missing alignment check in write_bytes)
Remove Span::eq_ctxt() #165012 (Remove Span::eq_ctxt())
[tiny] Add missing backticks around lifetime name #165013 ([tiny] Add missing backticks around lifetime name)
rustdoc-search: rank re-export lower #165024 (rustdoc-search: rank re-export lower)
Update enzyme submodule to fix one bug related to higher-order derivatives #165028 (Update enzyme to fix one bug related to higher-order derivatives)

Previously, expressions behind stmt_expr_attributes were only rejected when the cfg condition evaluated to false. If the condition was true, the code compiled successfully. This meant code like an attributed binary operand could compile on one platform but fail on another, even though removing the operand would leave an invalid expression. This change always rejects cfg in expression positions where removing the expression would produce invalid code. Expression positions where removal is safe continue to work as before. Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>

``` error[E0310]: the parameter type `R` may not live long enough --> $DIR/implicit-static-lifetime-in-dyn-trait-return-type.rs:10:5 | LL | fn bb<R>(r: R) -> Box<dyn Foo> { | ------- this `dyn Trait` has an implicit `'static` lifetime bound 3 LL | Box::new(Bar(r)) | ^^^^^^^^^^^^^^^^ | | | the parameter type `R` must be valid for the static lifetime... | ...so that the type `R` will meet its required lifetime bounds | help: consider adding an explicit lifetime bound | LL | fn bb<R: 'static>(r: R) -> Box<dyn Foo> { | +++++++++ help: consider adding an explicit lifetime bound | LL | fn bb<'a, R>(r: R) -> Box<dyn Foo + 'a> { | +++ ++++ ```

Report the same error for true and false cfg predicates when the surrounding expression cannot be removed. Apply it consistently during normal expansion and cfg_eval. Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>

This is the abstraction that clang/flang both use. It simplifies the code by quite a bit (although not until we delete the old version). Mainly this enables the use of the NewPM for LLVM targets that opt-in (currently only Lanai and MSP430, but more soon).

It's an error to have `#[inline]#[rustc_force_inline]fn blah(){}`, but they both lower to the same `InlineAttr`, so this would error and then have an attribute list of multiple inline attrs

``` error[E0803]: cannot infer an appropriate lifetime for lifetime parameter `'s` in generic type due to conflicting requirements ```

Fixes a side effect of 127a5d9 reported on Zulip.

…e to get span

…td::no_code` macro

…th separator

jhpratt · 2026-10-28T03:15:59Z

@bors try jobs=test-aarch64-apple-macos-26-2

Rollup of 21 pull requests try-job: test-aarch64-apple-macos-26-2

tgross35 · 2026-10-28T04:08:03Z

The hosted runner lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors retry

That's been the spurious failure of the week unfortunately, likely related to the disk space issues

…uwer Rollup of 21 pull requests Successful merges: - #159580 (Reject cfg on expressions that cannot be safely removed) - #162597 (raise ambiguity error on attribute macro that could be tool attribute) - #162808 (Enable `--generate-link-to-definition` rustdoc option on std docs) - #163059 (Recover invalid return type until `{`, `}` or `;`) - #163672 (Use runCodeGen Abstraction for new LLVM) - #164028 (Add a future incompat warning for #[no_link]) - #164188 (Suggest adding lifetime for `dyn Trait` in return type) - #164345 (fix: handle `false` in root contexts) - #164494 (drop ands which are a superset of other ands) - #164785 (delegation: emit error when there is no field for `Self` mapping) - #164799 (Don't use `IntoIterator` in parallel API) - #164871 (Refactor call argument codegen) - #164648 (parse inline and rustc_force_inline with same parser) - #164811 (fix: Prevent ICE when comparing EII impl against generic declaration) - #164900 (make tool_attrs method to retrieve tool attributes.) - #164993 (copy_nonoverlapping: dont skip ovelrap check when src is fully uninit) - #164996 (miri: add missing alignment check in write_bytes) - #165012 (Remove Span::eq_ctxt()) - #165013 ([tiny] Add missing backticks around lifetime name) - #165024 (rustdoc-search: rank re-export lower) - #165028 (Update enzyme to fix one bug related to higher-order derivatives)

rust-bors · 2026-10-28T06:00:17Z

☀️ Try build successful (CI)
Build commit: db4f935 (db4f9357d5d00415c98e61be464e37e9d2eb714a)
Base parent: 41089d0 (41089d07a0a2afc16adfe28a760d94d73d7298a4)

rust-log-analyzer · 2026-10-28T06:36:14Z

The job test-x86_64-gnu failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-10-28T06:37:15Z

💔 Test for 0cf65bb failed: CI. Failed job:

auto - test-x86_64-gnu (web logs, enhanced plaintext logs)

tgross35 · 2026-10-28T06:40:38Z

@bors retry

This time, it's this spurious error #t-compiler/rust-analyzer > miri failing test

jhpratt · 2026-10-28T06:41:13Z

What's the record for the most retries 🤔

tgross35 · 2026-10-28T06:50:16Z

Has to be getting close! I felt lucky when I got three of the same spurious failures in a row at #128349

…uwer Rollup of 21 pull requests Successful merges: - #159580 (Reject cfg on expressions that cannot be safely removed) - #162597 (raise ambiguity error on attribute macro that could be tool attribute) - #162808 (Enable `--generate-link-to-definition` rustdoc option on std docs) - #163059 (Recover invalid return type until `{`, `}` or `;`) - #163672 (Use runCodeGen Abstraction for new LLVM) - #164028 (Add a future incompat warning for #[no_link]) - #164188 (Suggest adding lifetime for `dyn Trait` in return type) - #164345 (fix: handle `false` in root contexts) - #164494 (drop ands which are a superset of other ands) - #164785 (delegation: emit error when there is no field for `Self` mapping) - #164799 (Don't use `IntoIterator` in parallel API) - #164871 (Refactor call argument codegen) - #164648 (parse inline and rustc_force_inline with same parser) - #164811 (fix: Prevent ICE when comparing EII impl against generic declaration) - #164900 (make tool_attrs method to retrieve tool attributes.) - #164993 (copy_nonoverlapping: dont skip ovelrap check when src is fully uninit) - #164996 (miri: add missing alignment check in write_bytes) - #165012 (Remove Span::eq_ctxt()) - #165013 ([tiny] Add missing backticks around lifetime name) - #165024 (rustdoc-search: rank re-export lower) - #165028 (Update enzyme to fix one bug related to higher-order derivatives)

rdrpenguin04 · 2026-10-28T13:46:44Z

test-aarch64-apple-macos-26-2 might be stuck?

JonathanBrouwer · 2026-10-28T13:48:37Z

It looks to be still making progress actually, just very slowly. Lets let it live for now?

rust-bors · 2026-10-28T14:08:39Z

💔 Test for f7ed956 failed: CI. Failed job:

auto - test-aarch64-apple-macos-26-2 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-10-28T14:08:43Z

The job test-aarch64-apple-macos-26-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Important

For more information how to resolve CI failures of this job, visit this link.

JonathanBrouwer · 2026-10-28T14:08:46Z

@bors retry

mejrs and others added 30 commits October 21, 2026 23:41

raise ambiguity error on attribute macro that looks like tool attribute

34a8d25

add no_implicit_prelude test

168e53d

AttrItem: remove id field

836cabb

Split Attribute::Unparsed into Tool and DeriveHelper

d105f7a

make tool_attrs method to retrieve tool attributes.

1026f1b

copy_nonoverlapping: dont skip ovelrap check when src is fully uninit

50871c8

miri: add missing alignment check in write_bytes

50031df

Remove handling for PassMode::Direct aggregates

843ede5

Refactor call argument codegen

50f2c19

Use a cfg-specific error for unsupported positions

be649c0

Report the same error for true and false cfg predicates when the surrounding expression cannot be removed. Apply it consistently during normal expansion and cfg_eval. Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>

parse inline and rustc_force_inline with same parser

b749d20

It's an error to have `#[inline]#[rustc_force_inline]fn blah(){}`, but they both lower to the same `InlineAttr`, so this would error and then have an attribute list of multiple inline attrs

inline calls to Span::eq_ctxt()

b5978be

remove Span::eq_ctxt()

ddb20b9

[tiny] Add missing backticks around lifetime name

3472da4

``` error[E0803]: cannot infer an appropriate lifetime for lifetime parameter `'s` in generic type due to conflicting requirements ```

update comments for unused-parens-macro-pat-issue-86959 lint test

eb44caa

rustdoc-search: rank re-export lower

a1dc0ab

Fixes a side effect of 127a5d9 reported on Zulip.

Update enzyme to fix one bug related to higher-order derivatives

83f8d53

fix: handle false in root contexts

9d230f2

feat: update destructure_type_outlives_constraints_in_root return typ…

6aae980

…e to get span

update destructure_type_outlives_constraints_in_root method return type

675c997

Enable --generate-link-to-definition rustdoc option on std docs

800ff08

Create new builtin rustc macro rustdoc_skip_body and replace the `s…

f6db3da

…td::no_code` macro

Disable unused_macros check on rustdoc_skip_body

4d2c7ad

Ignore more std functions body

b8a7bef

Stop using Path on Windows to generate URLs because of wrong \ pa…

6623b95

…th separator

drop ands which are a superset of other ands

1e90031

feat: add new simple test

e2ebb15

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 28, 2026

Auto merge of #165056 - JonathanBrouwer:rollup-ZFCUK9j, r=<try>

db4f935

Rollup of 21 pull requests try-job: test-aarch64-apple-macos-26-2

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2026

rust-bors Bot mentioned this pull request Oct 28, 2026

compiler-builtins subtree update #165016

Open

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2026

Conversation

JonathanBrouwer commented Oct 27, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Oct 28, 2026

Uh oh!

This comment has been minimized.

tgross35 commented Oct 28, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 28, 2026

Uh oh!

rust-log-analyzer commented Oct 28, 2026

Uh oh!

rust-bors Bot commented Oct 28, 2026

Uh oh!

tgross35 commented Oct 28, 2026

Uh oh!

jhpratt commented Oct 28, 2026

Uh oh!

tgross35 commented Oct 28, 2026

Uh oh!

This comment has been minimized.

rdrpenguin04 commented Oct 28, 2026

Uh oh!

JonathanBrouwer commented Oct 28, 2026

Uh oh!

rust-bors Bot commented Oct 28, 2026

Uh oh!

rust-log-analyzer commented Oct 28, 2026

Uh oh!

JonathanBrouwer commented Oct 28, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

JonathanBrouwer commented Oct 27, 2026 •

edited by rustbot

Loading