Repository navigation
Conversation
The crate is now on Rust 2024 so `rust_2018_idioms` isn't relevant.
tgross35
force-pushed
the
test-updates
branch
2 times, most recently
from
October 29, 2026 11:05
7ec47d9 to
44bb8b1
Compare
Looking for TARGET in proc macros is a bit of a hack: we have to parse it ourselves and it's not set by Cargo (as I understand it, proc macro output is supposed to be target-agnostic). Address this by moving logic based on `TARGET` into `cfg` that gets emitted as part of quoting. Also a bit of other cleanup. This fixes `macro_test` detection for a handful of targets (e.g. armv5te- or mipsisa64r6el- prefixes), not that those were likely to get run anyway.
tgross35
force-pushed
the
test-updates
branch
from
October 29, 2026 12:05
44bb8b1 to
a7cdecb
Compare
tgross35
changed the title
tgross35
marked this pull request as ready for review
October 29, 2026 12:07
Collaborator
|
r? @adamgemmell rustbot has assigned @adamgemmell. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking for TARGET in proc macros is a bit of a hack: we have to parse
it ourselves and it's not set by Cargo (as I understand it, proc macro
output is supposed to be target-agnostic).
Address this by moving logic based on
TARGETintocfgthat getsemitted as part of quoting. Also a bit of other cleanup.
This fixes
macro_testdetection for a handful of targets (e.g.armv5te- or mipsisa64r6el- prefixes), not that those were likely to get
run anyway.
The first two commits just do small cleanup and update
syn.