Skip to content

Match Windows terminal appearance and split geometry - #1009

Merged
coneilen merged 5 commits into
mainfrom
coneilen-windows-terminal-surface-parity-plan
Nov 12, 2026
Merged

coneilen merged 5 commits into
mainfrom
coneilen-windows-terminal-surface-parity-plan

Conversation

@coneilen

Copy link
Copy Markdown
Collaborator

Summary

Match the Windows terminal surface's host-owned appearance to macOS for the first #775 slice: the terminal now uses the canvas tone at 80% opacity, 2-point inner padding, and one DPI-scaled point between split panes. The pinned Winghostty provider supplies the appearance ABI while GraphCode preserves existing font and DPI ownership.

Changes

  • Pin Winghostty cac8f5f148fd5015d49e81e169ce9006ac7156ea (origin/coneilen-friendly-adventure) and update terminal provider-pin mirrors and provenance fixtures.
  • Apply #0A0C0B at 0.80 opacity and 2-point padding on all edges to every created terminal surface, with provider refusal propagated before publication.
  • Reserve split-divider pixels from both horizontal and vertical pane bounds, paint one seam, and subtract terminal padding from PTY/grid dimensions.
  • Preserve JetBrains Mono 11.7 pt, ordered symbol fallbacks, neutral font_scale, provider DPI conversion, and the existing terminal input/VT paths.
  • Keep App.zig and shared capture/harness behavior unchanged; paired live visual evidence remains outside this first slice.

Test plan

RED: & D:\depot\copilot-worktrees\GraphCode\coneilen-curly-bassoon.graphcode-tools\zig-0.15.2\zig.exe test src\TerminalSurface.zig -target x86_64-windows-msvc -lc -luser32 -lkernel32 -ID:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\include D:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\zig-out\lib\winghostty-win32-host.lib zig-out\lib\ghostty-vt-static.lib -lgdi32 -lopengl32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp --test-filter "pane bounds reserve one macOS divider point" -> 0 passed; 2 failed as expected: expected right x 411, found 410; expected vertical height 170, found 159
GREEN: & D:\depot\copilot-worktrees\GraphCode\coneilen-curly-bassoon.graphcode-tools\zig-0.15.2\zig.exe test src\TerminalSurface.zig -target x86_64-windows-msvc -lc -luser32 -lkernel32 -ID:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\include D:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\zig-out\lib\winghostty-win32-host.lib zig-out\lib\ghostty-vt-static.lib -lgdi32 -lopengl32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp --test-filter "pane bounds reserve one macOS divider point" -> 2/2 passed
REGRESSION: & D:\depot\copilot-worktrees\GraphCode\coneilen-curly-bassoon.graphcode-tools\zig-0.15.2\zig.exe test src\TerminalSurface.zig -target x86_64-windows-msvc -lc -luser32 -lkernel32 -ID:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\include D:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\zig-out\lib\winghostty-win32-host.lib zig-out\lib\ghostty-vt-static.lib -lgdi32 -lopengl32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp -> 313/313 passed

Additional Tier A evidence:

  • Terminal appearance focused filter -> 2/2 passed.
  • Terminal DPI divider filter -> 1/1 passed.
  • Terminal padded-grid filter -> 1/1 passed.
  • & D:\depot\copilot-worktrees\GraphCode\coneilen-curly-bassoon\.graphcode-tools\zig-0.15.2\zig.exe build -Doptimize=ReleaseSafe -Dwinghostty-dir=D:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure -> ReleaseSafe graphcode-windows.exe build passed.
  • pwsh -NoProfile -File Tools\windows\Tests\ProviderPins.Tests.ps1 -> Provider pin no-divergence contracts: PASS.
  • pwsh -NoProfile -File Tools\windows\Tests\PreviewCore.Tests.ps1 -> PREVIEW_CORE_CONTRACTS: executed=37; failed=0.
  • pwsh -NoProfile -File Tools\windows\Tests\VisualBaseline.Tests.ps1 -> VisualBaseline.Tests.ps1: PASS.
  • git ls-remote https://github.com/coneilen/winghostty.git refs/heads/coneilen-friendly-adventure and gh api repos/coneilen/winghostty/commits/cac8f5f148fd5015d49e81e169ce9006ac7156ea --jq '.sha' -> both resolved exactly cac8f5f148fd5015d49e81e169ce9006ac7156ea.

Tier B exact-head PR workflows and Tier C live-backend/paired macOS-Windows visual qualification were not run. This commit is not a claim that #775's four rendered-look boxes are fully validated.

Candidate and evidence identity

  • Tier(s): Tier A
  • Branch: coneilen-windows-terminal-surface-parity-plan
  • HEAD / tree: 42bcb46 / 9ed6c33d9d3e7a63ba2547886d2cd9d9597f0f71 (dirty)
  • Candidate hashes: provider pin cac8f5f148fd5015d49e81e169ce9006ac7156ea; graphcode-windows\provider-pins.json SHA-256 c2b5b3cfe74c5bae31d0cceebf02e363d113afe4338e6d5e3df2bb1e13672481; graphcode-windows\src\TerminalSurface.zig SHA-256 f22d50432891db44943a6710d9c67f764294a1c1aa76a53d5f14a384da0fa296.

Stopping handoff

  • Next exact command: pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -SkipTrayLive -ShellValidationRoot C:\gc-terminal-775 -SwiftExecutable $env:GRAPHCODE_SWIFT633
  • Positive count: Expect a positive full windows-shell test count, passing TerminalSurface.zig execution, release build, provider smoke, and native UIA gate; local Tier A evidence is 313/313 plus 37/37 PreviewCore contracts.
  • Permissions / time / desktop: No separately admitted live/native desktop qualification was run.
  • Blocker category: permissions/time/desktop
  • Evidence paths: session-local files\terminal-775\terminal-surface-final-head.log and files\terminal-775\terminal-surface-full-final.log; repository provider-pin and focused test contracts remain reproducible from the candidate.
  • Stopping condition: Stop at Tier A; require all exact-head PR workflows and separately admitted real zmx/production/paired macOS-Windows visual evidence before promoting Windows parity: Terminal surface matches the macOS terminal look #775 or making a visual-parity claim.
  • Publication authority: The coordinator controls push/PR and Tier B/Tier C promotion; neither was performed in this lane.

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally (make test) (macOS-only target; not applicable to this Windows-only PR)
  • Code follows the existing style (make check) (macOS-only target; Windows diff and focused contracts were checked)
  • I added the test/contract before the implementation and observed the intended RED failure
  • The evidence tier is explicit and the frozen candidate tuple matches the cited evidence
  • Any failure was classified and preserved before correction or retry

coneilen and others added 5 commits November 11, 2026 17:11
Apply the pinned Winghostty appearance contract and reserve macOS-equivalent terminal padding and split dividers while preserving font and DPI ownership.

Signed-off-by: Colin Neilens <coneilen@microsoft.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…inal-surface-parity-plan

Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Keep Actual Size separate, bound Fit Canvas normalization, require material owned card intersections, and retain final snapshot and screenshot diagnostics. Cover visible-after-fit and never-visible refusal with controlled pure tests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…inal-surface-parity-plan

Signed-off-by: Colin Neilens <coneilen@microsoft.com>
@coneilen
coneilen merged commit 0951957 into main Nov 12, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant