Repository navigation
Match Windows terminal appearance and split geometry - #1009
Merged
Merged
Conversation
Apply the pinned Winghostty appearance contract and reserve macOS-equivalent terminal padding and split dividers while preserving font and DPI ownership. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…inal-surface-parity-plan Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Keep Actual Size separate, bound Fit Canvas normalization, require material owned card intersections, and retain final snapshot and screenshot diagnostics. Cover visible-after-fit and never-visible refusal with controlled pure tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
…inal-surface-parity-plan Signed-off-by: Colin Neilens <coneilen@microsoft.com>
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match the Windows terminal surface's host-owned appearance to macOS for the first #775 slice: the terminal now uses the canvas tone at 80% opacity, 2-point inner padding, and one DPI-scaled point between split panes. The pinned Winghostty provider supplies the appearance ABI while GraphCode preserves existing font and DPI ownership.
Changes
cac8f5f148fd5015d49e81e169ce9006ac7156ea(origin/coneilen-friendly-adventure) and update terminal provider-pin mirrors and provenance fixtures.#0A0C0Bat 0.80 opacity and 2-point padding on all edges to every created terminal surface, with provider refusal propagated before publication.font_scale, provider DPI conversion, and the existing terminal input/VT paths.App.zigand shared capture/harness behavior unchanged; paired live visual evidence remains outside this first slice.Test plan
RED: & D:\depot\copilot-worktrees\GraphCode\coneilen-curly-bassoon.graphcode-tools\zig-0.15.2\zig.exe test src\TerminalSurface.zig -target x86_64-windows-msvc -lc -luser32 -lkernel32 -ID:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\include D:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\zig-out\lib\winghostty-win32-host.lib zig-out\lib\ghostty-vt-static.lib -lgdi32 -lopengl32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp --test-filter "pane bounds reserve one macOS divider point" -> 0 passed; 2 failed as expected: expected right x 411, found 410; expected vertical height 170, found 159
GREEN: & D:\depot\copilot-worktrees\GraphCode\coneilen-curly-bassoon.graphcode-tools\zig-0.15.2\zig.exe test src\TerminalSurface.zig -target x86_64-windows-msvc -lc -luser32 -lkernel32 -ID:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\include D:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\zig-out\lib\winghostty-win32-host.lib zig-out\lib\ghostty-vt-static.lib -lgdi32 -lopengl32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp --test-filter "pane bounds reserve one macOS divider point" -> 2/2 passed
REGRESSION: & D:\depot\copilot-worktrees\GraphCode\coneilen-curly-bassoon.graphcode-tools\zig-0.15.2\zig.exe test src\TerminalSurface.zig -target x86_64-windows-msvc -lc -luser32 -lkernel32 -ID:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\include D:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure\zig-out\lib\winghostty-win32-host.lib zig-out\lib\ghostty-vt-static.lib -lgdi32 -lopengl32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp -> 313/313 passed
Additional Tier A evidence:
& D:\depot\copilot-worktrees\GraphCode\coneilen-curly-bassoon\.graphcode-tools\zig-0.15.2\zig.exe build -Doptimize=ReleaseSafe -Dwinghostty-dir=D:\depot\copilot-worktrees\winghostty\coneilen-friendly-adventure-> ReleaseSafegraphcode-windows.exebuild passed.pwsh -NoProfile -File Tools\windows\Tests\ProviderPins.Tests.ps1->Provider pin no-divergence contracts: PASS.pwsh -NoProfile -File Tools\windows\Tests\PreviewCore.Tests.ps1->PREVIEW_CORE_CONTRACTS: executed=37; failed=0.pwsh -NoProfile -File Tools\windows\Tests\VisualBaseline.Tests.ps1->VisualBaseline.Tests.ps1: PASS.git ls-remote https://github.com/coneilen/winghostty.git refs/heads/coneilen-friendly-adventureandgh api repos/coneilen/winghostty/commits/cac8f5f148fd5015d49e81e169ce9006ac7156ea --jq '.sha'-> both resolved exactlycac8f5f148fd5015d49e81e169ce9006ac7156ea.Tier B exact-head PR workflows and Tier C live-backend/paired macOS-Windows visual qualification were not run. This commit is not a claim that #775's four rendered-look boxes are fully validated.
Candidate and evidence identity
coneilen-windows-terminal-surface-parity-plancac8f5f148fd5015d49e81e169ce9006ac7156ea;graphcode-windows\provider-pins.jsonSHA-256c2b5b3cfe74c5bae31d0cceebf02e363d113afe4338e6d5e3df2bb1e13672481;graphcode-windows\src\TerminalSurface.zigSHA-256f22d50432891db44943a6710d9c67f764294a1c1aa76a53d5f14a384da0fa296.Stopping handoff
pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -SkipTrayLive -ShellValidationRoot C:\gc-terminal-775 -SwiftExecutable $env:GRAPHCODE_SWIFT633windows-shelltest count, passingTerminalSurface.zigexecution, release build, provider smoke, and native UIA gate; local Tier A evidence is 313/313 plus 37/37 PreviewCore contracts.files\terminal-775\terminal-surface-final-head.logandfiles\terminal-775\terminal-surface-full-final.log; repository provider-pin and focused test contracts remain reproducible from the candidate.Checklist
git commit -s) per the DCOmake test) (macOS-only target; not applicable to this Windows-only PR)make check) (macOS-only target; Windows diff and focused contracts were checked)