Skip to content

fix: drop unhashed pyinstaller install - #48

Merged
Joeri-Abbo merged 1 commit into
mainfrom
fix/pyinstaller-unhashed-install
Sep 26, 2026
Merged

Joeri-Abbo merged 1 commit into
mainfrom
fix/pyinstaller-unhashed-install

Conversation

@Joeri-Abbo

Copy link
Copy Markdown
Member

Summary

  • Remove pip install pyinstaller==v6.13.0 from the binary build step. It installed PyInstaller from PyPI without hash verification, bypassing configs/pip/pyinstaller/requirements.txt (v6.19.0, hash-pinned, Dependabot-managed).
  • Call python3 -m PyInstaller so the hash-verified --user install is used regardless of whether ~/.local/bin is on PATH.

Found by a security scan (Low: supply-chain hardening).

Test plan

  • Tag build of a consumer repo with pyinstaller-binary-name set produces the binary

🤖 Generated with Claude Code

The hardcoded `pip install pyinstaller==v6.13.0` bypassed the hash-pinned
requirements file and was not tracked by Dependabot. Invoke PyInstaller
via `python3 -m` so the hash-verified --user install is used regardless
of PATH.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Joeri-Abbo
Joeri-Abbo force-pushed the fix/pyinstaller-unhashed-install branch from 57ddddf to d1a2438 Compare September 26, 2026 14:07
@Joeri-Abbo
Joeri-Abbo merged commit c1be9a4 into main Sep 26, 2026
@Joeri-Abbo
Joeri-Abbo deleted the fix/pyinstaller-unhashed-install branch September 26, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants