Repository navigation
Conversation
| - name: Generate release note | ||
| run: pixi run --script tools/collect-release-notes.py -- --cur-tag ${PACKAGE}/${VERSION} --compare-tag ${PACKAGE}/${LASTVERSION} | ||
| env: | ||
| # We have no lock files for scripts |
There was a problem hiding this comment.
Can we add a bit more description here as to why we don't want lock files. Because someone later might just come along and think 'why not?' and just add them?
| @@ -1,8 +1,13 @@ | |||
| # /// script | |||
| # requires-python = ">=3.12" | |||
| # dependencies = [] | |||
There was a problem hiding this comment.
Why do we need this? It is not in the other files.
| # platforms = [ | ||
| # "linux-64", | ||
| # { platform = "osx-arm64", macos = "14.0" }, | ||
| # ] |
There was a problem hiding this comment.
Don't we support windows?
Even if his is just for the CI builds, we have weekly builds on mac and windows?
There was a problem hiding this comment.
See the readme. I wanted to keep the lock files small. The weekly builds do not use any scripts as far as I can tell. Do you want me to add that anyway?
There was a problem hiding this comment.
Not sure which readme you are refering to...
If the weekly builds don't use any scripts, do we need macos in there or can we make do with just linux?
All I'm saying is that as it looks now, the next person who will read this will wonder "did we forget windows? Or maybe we should remove macos?"
There was a problem hiding this comment.
I forgot to commit it and it's on my workstation... I'll add it when I'm back in the office.
All I'm saying is that as it looks now, the next person who will read this will wonder "did we forget windows? Or maybe we should remove macos?"
I added macos initially because some of us use it. Added windows now.
| @@ -171,6 +171,8 @@ jobs: | |||
| run: ls .ess_release_cache | |||
| - name: Generate release note | |||
| run: pixi run --script tools/collect-release-notes.py -- --cur-tag ${PACKAGE}/${VERSION} --compare-tag ${PACKAGE}/${LASTVERSION} | |||
There was a problem hiding this comment.
Is there a way we can test that this command actually works now?
There was a problem hiding this comment.
Not without running the workflow. Can we still run the workflow from the UI and have it run all steps except the actual upload?
nvaytet
left a comment
There was a problem hiding this comment.
Approval pending addition of the README file
Currently, running the script fails with
(Reported by @nvaytet)
We would either need a lock file for the script (https://pixi.prefix.dev/latest/python/scripts/#lock-exact-versions) or allow resolving dependencies. This PR implements the latter.
Note that we need
PIXI_NO_INSTALL: falsein either case.