Skip to content

[CI] Add pixi lockfiles for scripts #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jl-wynen wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[CI] Add pixi lockfiles for scripts #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56d57a1
Do not require lockfiles for CI scripts
jl-wynen Oct 26, 2026
ed16996
Add script lock files
jl-wynen Oct 26, 2026
5bc2173
Remove empty dependencies
jl-wynen Oct 27, 2026
d52c104
Support windows in scripts
jl-wynen Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ jobs:
run: ls .ess_release_cache
- name: Generate release note
run: pixi run --script tools/collect-release-notes.py -- --cur-tag ${PACKAGE}/${VERSION} --compare-tag ${PACKAGE}/${LASTVERSION}

@nvaytet nvaytet Oct 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can test that this command actually works now?

@jl-wynen jl-wynen Oct 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not without running the workflow. Can we still run the workflow from the UI and have it run all steps except the actual upload?

env:
PIXI_NO_INSTALL: false
- name: Download existing release note
env:
GH_TOKEN: ${{ github.token }}
Expand Down
5 changes: 5 additions & 0 deletions tools/bump-dependency-version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
#
# [tool.pixi.workspace]
# channels = ["conda-forge"]
# platforms = [
# "linux-64",
# { platform = "osx-arm64", macos = "14.0" },
# "win-64",
# ]

@nvaytet nvaytet Oct 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we support windows?
Even if his is just for the CI builds, we have weekly builds on mac and windows?

@jl-wynen jl-wynen Oct 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the readme. I wanted to keep the lock files small. The weekly builds do not use any scripts as far as I can tell. Do you want me to add that anyway?

@nvaytet nvaytet Oct 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure which readme you are refering to...
If the weekly builds don't use any scripts, do we need macos in there or can we make do with just linux?

All I'm saying is that as it looks now, the next person who will read this will wonder "did we forget windows? Or maybe we should remove macos?"

@jl-wynen jl-wynen Oct 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to commit it and it's on my workstation... I'll add it when I'm back in the office.

All I'm saying is that as it looks now, the next person who will read this will wonder "did we forget windows? Or maybe we should remove macos?"

I added macos initially because some of us use it. Added windows now.

# ///

import argparse
Expand Down
Loading