Skip to content

Fix duplicate New-MonkeyDiagnosticSettingObject dropping resources - #197

Merged
silverhack merged 1 commit into
silverhack:developfrom
JoePhanDro:fix/duplicate-diagnostic-setting-object
Oct 22, 2026
Merged

silverhack merged 1 commit into
silverhack:developfrom
JoePhanDro:fix/duplicate-diagnostic-setting-object

Conversation

@JoePhanDro

Copy link
Copy Markdown
Contributor

Rename the helpers/diagnosticSettings variant to New-MonkeyAzDiagnosticObject so it no longer shadows the null-tolerant utils version. Return the input object from Get-MonkeyAzDiagnosticSettingForResource on error when -AddToObject is set.

Fixes #196

Context

Please include a summary of the changes. Please also include relevant motivation and context for this PR.

Description

Please include a summary of the change and which issue is fixed.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Rename the helpers/diagnosticSettings variant to New-MonkeyAzDiagnosticObject
so it no longer shadows the null-tolerant utils version. Return the input
object from Get-MonkeyAzDiagnosticSettingForResource on error when
-AddToObject is set.

Fixes silverhack#196
@github-actions

Copy link
Copy Markdown
Contributor

Pull request targets main

This pull request cannot be merged because only the repository's
develop branch may be merged into main.

For a feature or bug fix, change the pull request's base branch to
develop. The maintainer will promote tested changes from develop
to main as part of the release process.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@silverhack
silverhack changed the base branch from main to develop October 22, 2026 17:42
@silverhack
silverhack merged commit d3abcad into silverhack:develop Oct 22, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.0.0: resources without a diagnostic setting silently drop out of the Azure inventory (duplicate New-MonkeyDiagnosticSettingObject)

2 participants