Skip to content

Fix duplicate New-MonkeyDiagnosticSettingObject dropping resources #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silverhack merged 1 commit into from
Oct 22, 2026
Merged

Fix duplicate New-MonkeyDiagnosticSettingObject dropping resources #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...esourcemanagement/helpers/diagnosticSettings/Get-MonkeyAzDiagnosticSettingForResource.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ Function Get-MonkeyAzDiagnosticSettingForResource {
}
catch{
Write-Verbose $_
#Do not drop the resource if the lookup fails
If($AddToObject.IsPresent){
return $InputObject
}
}
}
}
4 changes: 2 additions & 2 deletions ...ngs/New-MonkeyDiagnosticSettingObject.ps1 → ...Settings/New-MonkeyAzDiagnosticObject.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

Function New-MonkeyDiagnosticSettingObject {
Function New-MonkeyAzDiagnosticObject {
<#
.SYNOPSIS
Create a new diagnostic setting object
Expand All @@ -29,7 +29,7 @@ Function New-MonkeyDiagnosticSettingObject {
.NOTES
Author : Juan Garrido
Twitter : @tr1ana
File Name : New-MonkeyDiagnosticSettingObject
File Name : New-MonkeyAzDiagnosticObject
Version : 1.0

.LINK
Expand Down
10 changes: 5 additions & 5 deletions ...resourcemanagement/helpers/storageaccount/Get-MonkeyAzStorageAccountDiagnosticSetting.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,39 +53,39 @@ Function Get-MonkeyAzStorageAccountDiagnosticSetting {
'root'{
$diag = $objectId | Get-MonkeyAzDiagnosticSettingsById
If($null -ne $diag){
$diag | New-MonkeyDiagnosticSettingObject
$diag | New-MonkeyAzDiagnosticObject
}
}
'blob'{
$blobEndpoint = ("{0}/blobServices/default" -f $objectId)
#Get diagnostic settings
$diag = $blobEndpoint | Get-MonkeyAzDiagnosticSettingsById
If($null -ne $diag){
$diag | New-MonkeyDiagnosticSettingObject
$diag | New-MonkeyAzDiagnosticObject
}
}
'queue'{
$queueEndpoint = ("{0}/queueServices/default" -f $objectId)
#Get diagnostic settings
$diag = $queueEndpoint | Get-MonkeyAzDiagnosticSettingsById
If($null -ne $diag){
$diag | New-MonkeyDiagnosticSettingObject
$diag | New-MonkeyAzDiagnosticObject
}
}
'table'{
$tableEndpoint = ("{0}/tableServices/default" -f $objectId)
#Get diagnostic settings
$diag = $tableEndpoint | Get-MonkeyAzDiagnosticSettingsById
If($null -ne $diag){
$diag | New-MonkeyDiagnosticSettingObject
$diag | New-MonkeyAzDiagnosticObject
}
}
'file'{
$fileEndpoint = ("{0}/fileServices/default" -f $objectId)
#Get diagnostic settings
$diag = $fileEndpoint | Get-MonkeyAzDiagnosticSettingsById
If($null -ne $diag){
$diag | New-MonkeyDiagnosticSettingObject
$diag | New-MonkeyAzDiagnosticObject
}
}
}
Expand Down
Loading