Skip to content

Resolve the conflicts and over-broad rules a second agent review found #2139

Closed

Description

@braboj

Part of #2124.

A second agent's read on 2026-10-22 found conflicts the first missed, and two rules that ask for more than their evidence supports. Each is checked against main.

Rule Conflicts with Scenario
core/agents.md:55 never restate a rule authoritative elsewhere :94, :131 inline every rule, or every silent one (MUST) generating the prescribed context file fails its own self-check
core/git.md:12 never commit reproducible generated files :71 stage a regenerated artifact with its source (MUST) a generated SVG the project tracks
security/security.md:169 never log PII :175 log user ID and IP; backend/auth.md:62 log the username; data/data-governance.md:28 IP is PII a failed login whose username is an email
backend/http.md:121 application/json on every JSON response :117 errors are application/problem+json (RFC 9457) any error response
Rule Problem
backend/caching.md:47 invalidation atomic with the write via outbox or pub/sub an outbox records intent atomically; delivery is later, so readers can see stale data
core/quality.md:14 delete a path when probing real data shows it never fires a sample can miss a rare legitimate case; unreachability needs evidence
core/quality.md:135 never make the CLI the product excludes legitimate CLI products without guiding a decision

Done when

  • Each conflict is resolved: one rule qualified or scoped
  • The caching rule states its consistency guarantee and stale window
  • The two quality rules require evidence, or keep only their intent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium — important but not blockingbugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions