Skip to content

Restore the conditions the score rewrites dropped #2142

Open

Description

@braboj

Part of #2124.

Reading the diffs of the score rewrites (#2107 to #2121) found five rules that lost a condition, a scope or a strength qualifier. v3.0.0 ships these rewrites.

PR Template Before After
#2109 backend/webhooks.md never run heavy work inline on the request path never inline
#2111 backend/edge.md API-gateway routing inside a service mesh is covered by the microservices template scope boundary gone
#2117 backend/microservices.md two services that change together are probably one service "Merge two services that keep changing together"
#2118 frontend/quality.md five patterns under "Prefer these patterns" plain imperatives, read as MUST
#2121 backend/api.md switching the authentication scheme is breaking "a new auth scheme", which adding one is not

Also, pre-existing: backend/microservices.md says the outbox makes a write and its event publish atomic. It makes the write and the outbox record atomic; the relay publishes later.

The other ten rewrites keep their conditions. The core-tier rewrites under #2024 are audited separately.

Done when

  • Each rule regains its condition, scope or strength
  • The outbox rule states what is atomic and what is not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium — important but not blockingbugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions