Repository navigation
fix: Re-emit existing discovery CM if listener is not ready - #1105
Merged
Merged
Conversation
adwk67
marked this pull request as ready for review
November 6, 2026 09:23
20 tasks
siegfriedweber
previously approved these changes
Nov 11, 2026
siegfriedweber
left a comment
Member
There was a problem hiding this comment.
LGTM
I have some comments that I would classify as "could have".
siegfriedweber
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of https://github.com/stackabletech/internal-issues/issues/167
kuttl: the
cluster-operationtest has a new step60-recreate-role-listenerthat deletes the role Listener and asserts that the discovery ConfigMap keeps its uid, data and resourceVersion once the Listener is re-created.Manual checks on kind, with product images at
stackableVersion: 26.3.0vs. the CI image built from this PR0.0.0-pr1105:-ZOOKEEPER/ZOOKEEPER_HOSTS. Druid, which copies the ZooKeeper address from this ConfigMap into its own config, rolls out once (as on 26.3) instead of twice (as on main).listenerClasschangeWhat users notice
26.3.0 and 26.7.0 handle the role Listener the same way: the operator does not watch Listeners,
and the cluster reconcile fails while the Listener has no address. The differences below apply
to an upgrade from either release.
ZOOKEEPERorZOOKEEPER_HOSTSvalues. On a fresh deploy, Druid rolls out once, the same as on 26.3.0.Compared with the current
main(unreleased), this PR removes the extra ConfigMap version withempty
ZOOKEEPER/ZOOKEEPER_HOSTSon every fresh deploy and every time the role Listener isre-created, and with it the extra rollout of consumers such as Druid that copy the address into
their own config.
ZookeeperZnode discovery ConfigMaps are unchanged by this PR: a ZookeeperZnode still fails its
reconcile until the role Listener has an address.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker