Make floatingPoolName optional - #280
Merged
Merged
Conversation
ske-prow
Bot
added
do-not-merge/work-in-progress
dergeberl
force-pushed
the
makeFloatingPoolNameOptional
branch
from
September 3, 2026 05:52
44fa5ed to
c1a39c4
Compare
ske-prow
Bot
added
size/M
Member
Author
|
/kind bug |
dergeberl
changed the title
ske-prow
Bot
removed
the
do-not-merge/work-in-progress
nschad
approved these changes
Sep 3, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nschad The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 777d383fb719a4b97dcc38d917671d5e51744534 |
ske-prow
Bot
added
the
approved
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
/cc @stackitcloud/ske-infrastructure
What this PR does / why we need it:
The
floatingPoolNamewas required but never used in a STACKIT only Cluster (since the validation is in place #212). It is only used in the STACKIT Infra-Controller in case there are OpenStack Credentials to pull the IDs of it in the Status.This PR removes the validation (we know we need it for clusters with OpenStack). To not make the unrelevant field for STACKIT Only clusters required.
There will be a followup PR (#281) which also further cleans up the
floatingPoolNameand other fields in theInfrastructureConfig.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: