fix: Replace the unsafe Yaml instantiation in ReferenceVisitor.getYam…#2344
Merged
Conversation
…l() with SafeConstructor
ewaostrowska
force-pushed
the
snakeyaml-constructor
branch
from
4e12bd1 to
6523a97
Compare
daniel-kmiecik
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request strengthens YAML parsing security in the
ReferenceVisitorclass by ensuring only safe YAML tags are allowed, and adds a test to verify that unsafe tags are rejected.getYaml()method inReferenceVisitorto always useSafeConstructorandLoaderOptions, ensuring that only safe YAML tags are processed and preventing deserialization of potentially unsafe Java objects.SafeConstructor,Representer, andDumperOptionsto support the new YAML instantiation approach