Skip to content

fix: Replace the unsafe Yaml instantiation in ReferenceVisitor.getYam… #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewaostrowska merged 1 commit into from
Jun 11, 2026
+13 −6
Merged

fix: Replace the unsafe Yaml instantiation in ReferenceVisitor.getYam… #2344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/reference/ReferenceVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@
import io.swagger.v3.parser.util.RemoteUrl;
import org.apache.commons.lang3.StringUtils;
import org.slf4j.LoggerFactory;
import org.yaml.snakeyaml.DumperOptions;
import org.yaml.snakeyaml.LoaderOptions;
import org.yaml.snakeyaml.Yaml;
import org.yaml.snakeyaml.constructor.SafeConstructor;
import org.yaml.snakeyaml.representer.Representer;

import java.util.HashMap;
import java.util.HashSet;
Expand Down Expand Up @@ -319,15 +322,13 @@ public JsonNode deserializeIntoTree(String content) throws Exception {
}

private Yaml getYaml() {
Yaml yaml;
String yamlCodePoints = System.getProperty("maxYamlCodePoints");
if (yamlCodePoints != null && !yamlCodePoints.isEmpty() && StringUtils.isNumeric(yamlCodePoints)) {
loaderOptions.setCodePointLimit(Integer.parseInt(yamlCodePoints));
yaml = new Yaml(loaderOptions);
} else {
yaml = new Yaml();
LoaderOptions opts = new LoaderOptions();
opts.setCodePointLimit(Integer.parseInt(yamlCodePoints));
return new Yaml(new SafeConstructor(opts), new Representer(new DumperOptions()), new DumperOptions(), opts);
}
return yaml;
return new Yaml(new SafeConstructor(new LoaderOptions()));
}

public JsonNode parse(String absoluteUri, List<AuthorizationValue> auths) throws Exception {
Expand Down
6 changes: 6 additions & 0 deletions .../swagger-parser-v3/src/test/java/io/swagger/v3/parser/reference/ReferenceVisitorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ public void largeFileShouldBeParsedByJacksonLibraryWhenCodeLimitIsSet() throws E
System.clearProperty("maxYamlCodePoints");
}

@Test(expectedExceptions = YAMLException.class)
public void unsafeYamlTagShouldBeRejected() throws Exception {
ReferenceVisitor visitor = new ReferenceVisitor(null, null, null, null);
visitor.deserializeIntoTree("!!javax.script.ScriptEngineManager [!!java.net.URLClassLoader [[]]]");
}

@Test
public void largeFileShouldNotBeParsedByJacksonLibraryWhenCodeLimitIsNotSet() throws Exception {
ReferenceVisitor visitor = new ReferenceVisitor(null, null, null, null);
Expand Down
Loading