[doctrine] Scope RequireQueryBuilderOnRepository to repository classes only - #306
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
doctrine.requireQueryBuilderOnRepositoryrule fired on every->createQueryBuilder()call that was not on a repository/connection type, regardless of where it lived.That flagged service, model, controller and test classes, where an EntityManager
createQueryBuilder()is the natural form and$this->createQueryBuilder()does not exist - pure false positives that could only be silenced with an ignore.Now the rule only reports inside repository classes (subclasses of
EntityRepository/DocumentRepository), where$this->createQueryBuilder()is a real, safer swap. Outside repositories it stays silent.Scope::getClassReflection()SkipNonRepositoryClasscovering the silenced service case