[doctrine] Scope RequireQueryBuilderOnRepository to repository classes only

src/Rules/Doctrine/RequireQueryBuilderOnRepositoryRule.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\ClassReflection;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\ObjectType;
@@ -38,6 +39,11 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        // only relevant inside repository classes, where $this->createQueryBuilder() is available as a safe swap
+        if (! $this->isInsideRepositoryClass($scope)) {
+            return [];
+        }
+
         $callerType = $scope->getType($node->var);
         if ($this->isValidRepositoryObjectType($callerType)) {
             return [];
@@ -50,6 +56,20 @@ public function processNode(Node $node, Scope $scope): array
         return [$identifierRuleError];
     }
 
+    private function isInsideRepositoryClass(Scope $scope): bool
+    {
+        $classReflection = $scope->getClassReflection();
+        if (! $classReflection instanceof ClassReflection) {
+            return false;
+        }
+
+        if ($classReflection->isSubclassOf(DoctrineClass::ENTITY_REPOSITORY)) {
+            return true;
+        }
+
+        return $classReflection->isSubclassOf(DoctrineClass::DOCUMENT_REPOSITORY);
+    }
+
     private function isValidRepositoryObjectType(Type $type): bool
     {
         if ($type instanceof UnionType) {

tests/Rules/Doctrine/RequireQueryBuilderOnRepositoryRule/Fixture/ReportOnDocumentManager.php

@@ -5,8 +5,9 @@
 namespace Symplify\PHPStanRules\Tests\Rules\Doctrine\RequireQueryBuilderOnRepositoryRule\Fixture;
 
 use Doctrine\ODM\MongoDB\DocumentManager;
+use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
 
-final class ReportOnDocumentManager
+final class ReportOnDocumentManager extends DocumentRepository
 {
     public function process(DocumentManager $documentManager)
     {

tests/Rules/Doctrine/RequireQueryBuilderOnRepositoryRule/Fixture/ReportOnEntityManager.php

@@ -5,9 +5,9 @@
 namespace Symplify\PHPStanRules\Tests\Rules\Doctrine\RequireQueryBuilderOnRepositoryRule\Fixture;
 
 use Doctrine\ORM\EntityManagerInterface;
-use Symplify\PHPStanRules\Tests\Rules\Doctrine\RequireQueryBuilderOnRepositoryRule\Source\RandomEntity;
+use Doctrine\ORM\EntityRepository;
 
-final class ReportOnEntityManager
+final class ReportOnEntityManager extends EntityRepository
 {
     public function process(EntityManagerInterface $entityManager)
     {

tests/Rules/Doctrine/RequireQueryBuilderOnRepositoryRule/Fixture/SkipNonRepositoryClass.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\Doctrine\RequireQueryBuilderOnRepositoryRule\Fixture;
+
+use Doctrine\ORM\EntityManagerInterface;
+
+final class SkipNonRepositoryClass
+{
+    public function process(EntityManagerInterface $entityManager)
+    {
+        $queryBuilder = $entityManager->createQueryBuilder();
+    }
+}

tests/Rules/Doctrine/RequireQueryBuilderOnRepositoryRule/RequireQueryBuilderOnRepositoryRuleTest.php

@@ -29,13 +29,14 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SkipCreateQueryBuilderOnRepository.php', []];
         yield [__DIR__ . '/Fixture/SkipDocumentRepository.php', []];
         yield [__DIR__ . '/Fixture/SkipConnection.php', []];
+        yield [__DIR__ . '/Fixture/SkipNonRepositoryClass.php', []];
 
         yield [__DIR__ . '/Fixture/ReportOnEntityManager.php', [
             [RequireQueryBuilderOnRepositoryRule::ERROR_MESSAGE, 14],
         ]];
 
         yield [__DIR__ . '/Fixture/ReportOnDocumentManager.php', [
-            [RequireQueryBuilderOnRepositoryRule::ERROR_MESSAGE, 13],
+            [RequireQueryBuilderOnRepositoryRule::ERROR_MESSAGE, 14],
         ]];
     }