Let the candidate hide the worked examples - #174
Conversation
|
@ascodeasice Your body ends with |
|
I've pushed three commits according to the review
The body now ends with Criterion 3, Jim not told the examples are on screen The page sends the choice to the server with the other interview options. When the examples are hidden, Jim's instructions say so instead of saying the screen shows one or two worked examples. A few hints and clarifications also point at the examples, such as "Look at the air cells on the right edge in the example". I would reword those so they make sense either way, rather than keep a second version for hidden examples. This changes the live prompt, so it comes with a prompt contract version bump. Would you rather have this in this PR, or as a follow-up once this one is in? Criterion 4, the input format in "Add a case" I see two ways to go, and would like your view on which:
If you prefer the first, I will edit #173 to match. |
Go ahead, minimizing scope for an issue and making collaboration easier. |
|
Pushed When the candidate ticks the box, the page sends Earlier I suggested rewording the hints and clarifications in the problem bank. I did not, because #173 keeps the bank out of scope. Instead, with the flag set, the prompt also tells Jim that when a hint or clarification mentions an example, he should use a case the candidate proposed or a small case of his own, and never point the candidate at the screen. I tried both modes in live sessions. With the examples shown, I asked Jim for an example, and he told me the examples were on my screen. With them hidden, he said there were none on my screen and asked me to propose my own cases first. With the examples hidden, I also tried a hint and a clarification that mention an example, on two problems:
Jim never sees the problem's examples in either mode, because they are not in the prompt. That is why he guessed at them in #182. When the fix for #182 puts them into the prompt, it can check |
jserv
left a comment
There was a problem hiding this comment.
Rebase the current branch onto the upstream default branch and rework the series into functionally minimal commits, folding similar ones and enforcing the project's commit message rules.
9eec154 to
9cb056d
Compare
|
Rebased onto main and folded the commits into three by function. I also rewrote the messages to say what changed and why, without the how, as the rules ask:
Also, I've updated my PR description from Refs #173 into Closes #173 since all the criteria are met now |
ColtenOuO
left a comment
There was a problem hiding this comment.
Please check the CI error report and resolve the issue.
9cb056d to
fea411e
Compare
The preflight card is taller than a laptop window once every step is shown, and the overlay pushed it past both edges, where neither the wheel nor the keyboard could reach the Start button. The overlay now scrolls and keeps the card's top in view, and a card that fits stays centered as before, including in a browser that does not understand safe centering.
The Example step asks the candidate for an ordinary and a boundary case while the Problem tab already shows one or two worked ones, so the step can be passed by reading them aloud. A preflight checkbox, stored like the Meet presentation choice, now leaves them off the page, along with the Add a case placeholder, which is the judge's first input and so a worked case of its own. The one brief that pointed at the examples, the topology replica's, now states the mesh format itself.
ColtenOuO
left a comment
There was a problem hiding this comment.
Please rebase and resolve the conflict.
Hiding the examples changed only the page, so the live prompt still told Jim the screen showed one or two worked examples, and a hint or clarification that mentions an example sent the candidate looking for one. The choice now reaches the prompt, which says none are on screen, has Jim put any example a hint or clarification mentions as a case of the candidate's or his own, and asks for the candidate's cases before he offers one. A session that does not hide them gets the prompt unchanged, and the problem bank stays out of scope as sysprog21#173 sets it. The live prompt moves to 15 and the bundle to 23.
fea411e to
2fdbadd
Compare
|
Thank @ascodeasice for contributing! |
What this does
Adds a "Hide the worked examples" checkbox to the preflight. The REACTO Example step asks the candidate for an ordinary and a boundary case, but the Problem tab already shows one or two examples, so the step can be passed by reading them aloud. When the box is ticked, the Problem tab shows the brief without the example blocks, so the candidate has to come up with the cases. The choice is remembered between visits, the same way as the Meet presentation checkbox. Without it, the page is unchanged.
Also fixes: the preflight could not scroll
The preflight card could not scroll when it was taller than the window, so on a laptop screen its top and the Start interview button were cut off with no way to reach them. This was already the case on main; the new checkbox makes the card taller and the problem easier to hit. The overlay now scrolls and keeps its top in view; a card that fits stays centered as before. This is a separate commit.
Not included
Jim is still told the examples are on screen, and "Add a case" does not yet show its input format when they are hidden. The first changes the live prompt, which needs a new prompt contract version, so it is left for a follow-up.
Validation
scripts/test.sh passes locally with Playwright Chromium installed (713 browser tests, none skipped); cargo-audit, ruff and shellcheck were not installed. A new browser test drives the real page: tick, reload, untick, and blocked storage. The scroll fix was checked by hand at 545 px and 1091 px window heights.
Closes #173
Closes #178
Summary by cubic
Adds a "Hide the worked examples" checkbox to the preflight so the Problem tab shows the brief without the worked cases, making the REACTO Example step require candidates to propose their own cases rather than read what's on screen. The choice is remembered between visits, like the Meet presentation checkbox, and also clears the "Add a case" input placeholder, which is a worked case in its own right. The topology replica brief no longer points at the example blocks.
The hide choice now reaches the interviewer: the page sends
hideExampleswith the token request, the server carries it through the participant metadata into the live prompt, which says no examples are on screen and offers a small example only after the candidate has tried or is stuck. A session that never ticks the box mints the same metadata and gets the live prompt unchanged. The live prompt moves to version 15 and the bundle to 23.Bug Fixes
safe centersupport, so the top and the Start button are reachable on laptop screens.Written for commit 2fdbadd. Summary will update on new commits.