Skip to content

Preserve test journals across subprocess assertions - #1357

Merged
taras merged 70 commits into
mainfrom
codex/1171-bounded-subprocess-journals
Nov 17, 2026
Merged

taras merged 70 commits into
mainfrom
codex/1171-bounded-subprocess-journals

Conversation

@taras

@taras taras commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Why

A subprocess can exit successfully before the parent test fails an assertion. The parent needs the child’s journal at that point. The CLI assembly fixture also runs five distinct profiles, each of which needs its own identity. Advances #1171 and builds on #1356.

What changes

  • Share the bounded fixture transport between the CLI assembly and Git ORC12 tests. They retain guarded snapshots in memory after the subprocess joins and persist them if the parent assertion fails.
  • Save each profile at its declared slot with its name and source in the sidecar. Report a fixed reason for an omitted snapshot and retain the valid siblings.
  • Use the attributed wrapper for additional guarded CLI, TestAgent, Agent, Core, REPL, and Testing cases.

Review guide

Start with the mixed-profile witness in packages/cli/tests/agent-adapters.test.ts and its transport in packages/test-support/subprocess-journal.ts. The signed transport correction is dbb05715b.

How to verify it

  • The real assembly fixture tests all five captures, a deliberately oversized Plan snapshot, and no files on success. The mixed failure preserves the original assertion and writes four correctly attributed journals.
  • Git ORC12 tests joined subprocess release, expected refusal, and a failure after exit. The helper suite covers malformed evidence and the size budget.
  • Focused Deno, Node 22.23.4, and Bun suites and both typechecks passed. The original Planner re-reviewed this signed revision and passed it.

Scope

This stack entry contains the shared subprocess transport and the signed migration batches above #1356. The remaining owner rollout continues under #1171.

Scope confirmation

  • Every changed file supports failure-journal capture or migration.
  • The description matches the signed revision and focused evidence.

taras added 26 commits November 16, 2026 13:22
@taras
taras added this pull request to stack #1386 November 17, 2026 12:00
@taras
taras marked this pull request as ready for review November 17, 2026 12:05
Base automatically changed from codex/test-case-journal-attribution-1171 to main November 17, 2026 12:17
@taras
taras merged commit 29dd178 into main Nov 17, 2026
64 checks passed
@taras
taras deleted the codex/1171-bounded-subprocess-journals branch November 17, 2026 12:57
taras added a commit that referenced this pull request Nov 17, 2026
Replay the reviewed #1358 patch onto squash-merged #1357.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant