Repository navigation
Preserve test journals across subprocess assertions - #1357
Merged
Merged
Conversation
2 tasks done
taras
added a commit
that referenced
this pull request
Nov 17, 2026
taras
marked this pull request as ready for review
November 17, 2026 12:05
Base automatically changed from
codex/test-case-journal-attribution-1171
to
main
November 17, 2026 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A subprocess can exit successfully before the parent test fails an assertion. The parent needs the child’s journal at that point. The CLI assembly fixture also runs five distinct profiles, each of which needs its own identity. Advances #1171 and builds on #1356.
What changes
Review guide
Start with the mixed-profile witness in
packages/cli/tests/agent-adapters.test.tsand its transport inpackages/test-support/subprocess-journal.ts. The signed transport correction isdbb05715b.How to verify it
Scope
This stack entry contains the shared subprocess transport and the signed migration batches above #1356. The remaining owner rollout continues under #1171.
Scope confirmation