Repository navigation
Capture journals in more guarded test harnesses - #1358
Merged
Merged
Conversation
2 tasks done
taras
added a commit
that referenced
this pull request
Nov 17, 2026
taras
added a commit
that referenced
this pull request
Nov 17, 2026
Base automatically changed from
codex/1171-bounded-subprocess-journals
to
main
November 17, 2026 12:57
taras
force-pushed
the
codex/1171-guarded-journal-migrations
branch
from
November 17, 2026 13:01
c5d4825 to
7f31609
Compare
taras
added a commit
that referenced
this pull request
Nov 17, 2026
taras
marked this pull request as ready for review
November 17, 2026 13:51
taras
added a commit
that referenced
this pull request
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fresh repository test executions in several harnesses discarded their in-memory journals when a later assertion failed. This stage gives those cases the shared failure-only capture introduced in #1356. Advances #1171 and builds on #1357.
What changes
Review guide
The ten signed commits group the changes by harness.
packages/core/tests/component-invocation-hooks.test.tsshows held execution.packages/cli/tests/repl-model.test.tsshows the boundary between a fresh run and a replay or history fixture.How to verify it
c84628f71.Scope
The inventory accounts for the original 237 rows. This stage leaves 106 pending and 51 partial rows in #1171 for the ongoing migration.
Scope confirmation