Skip to content

Capture journals in more guarded test harnesses - #1358

Merged
taras merged 1 commit into
mainfrom
codex/1171-guarded-journal-migrations
Nov 17, 2026
Merged

taras merged 1 commit into
mainfrom
codex/1171-guarded-journal-migrations

Conversation

@taras

@taras taras commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Why

Fresh repository test executions in several harnesses discarded their in-memory journals when a later assertion failed. This stage gives those cases the shared failure-only capture introduced in #1356. Advances #1171 and builds on #1357.

What changes

  • Attribute guarded Core, Agent, ACP, TestAgent, Testing, Git, Workflow, CLI Plan and Upgrade, and fresh REPL source ownership executions to their declared cases.
  • Keep separate journal scopes for tests that compare two executions. The scopes cover the comparisons and joined cleanup.
  • Keep seeded, replayed, explicit, and protected journals with the fixtures that exercise them.

Review guide

The ten signed commits group the changes by harness. packages/core/tests/component-invocation-hooks.test.ts shows held execution. packages/cli/tests/repl-model.test.ts shows the boundary between a fresh run and a replay or history fixture.

How to verify it

  • Each batch passed focused checks on applicable Deno, Node 22.23.4, and Bun suites, plus Deno and Node typechecks. Four Git suites use their existing Deno-only coverage.
  • Passing adoption batches left no automatic artifacts. The independent reviewer also checked that nested failures preserved the original error and produced separate attributed journals.
  • The Planner and independent Fable reviewer passed exact head c84628f71.

Scope

The inventory accounts for the original 237 rows. This stage leaves 106 pending and 51 partial rows in #1171 for the ongoing migration.

Scope confirmation

  • Every changed file supports the migration.
  • The description matches the signed change and focused verification.

taras added a commit that referenced this pull request Nov 17, 2026
@taras
taras added this pull request to stack #1386 November 17, 2026 12:00
Base automatically changed from codex/1171-bounded-subprocess-journals to main November 17, 2026 12:57
Replay the reviewed #1358 patch onto squash-merged #1357.
@taras
taras force-pushed the codex/1171-guarded-journal-migrations branch from c5d4825 to 7f31609 Compare November 17, 2026 13:01
taras added a commit that referenced this pull request Nov 17, 2026
@taras
taras marked this pull request as ready for review November 17, 2026 13:51
@taras
taras merged commit ae7424a into main Nov 17, 2026
64 checks passed
@taras
taras deleted the codex/1171-guarded-journal-migrations branch November 17, 2026 13:52
taras added a commit that referenced this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant