Repository navigation
Conversation
Shivs11
commented
Oct 20, 2026
| string stable_identity = 1; | ||
| } | ||
|
|
||
| message ActivitySessionOptions { |
Member
Author
There was a problem hiding this comment.
i envision these options to be sent on the command attributes when we are going to schedule an activity task -- if that is the case, i wonder if we should have something defined or thought of for the stable identity piece (single session isolation) given that we seem to have thought this in the poll request structures
if not, then i wonder if we do even need the single session options defined in the general WorkerSessionOptions
Shivs11
commented
Oct 20, 2026
Comment on lines
+17
to
+19
| oneof isolation { | ||
| SingleSessionOptions single_session = 1; | ||
| } |
Member
Author
There was a problem hiding this comment.
should we also have a boolean for use_workflow_session here?
Shivs11
commented
Oct 20, 2026
| // workflow task is dispatched. The server persists that workflow ID and does | ||
| // not forward subsequent polls, including after workflow completion. | ||
| // Activity sticky polls are never forwarded to the normal queue. | ||
| message SingleSessionOptions { |
Member
Author
There was a problem hiding this comment.
thomas: says that maybe we should think about what this is called if we wanna ActivitySessionOptions
- another thing that he says is that we may not require to think about introducing this right now given that this is experimental
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Breaking changes
Server PR