Repository navigation
Sticky activity session options #885
+58
−0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package temporal.api.session.v1; | ||
|
|
||
| option go_package = "go.temporal.io/api/session/v1;session"; | ||
| option java_package = "io.temporal.api.session.v1"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "MessageProto"; | ||
| option ruby_package = "Temporalio::Api::Session::V1"; | ||
| option csharp_namespace = "Temporalio.Api.Session.V1"; | ||
|
|
||
| // EXPERIMENTAL. Subject to redesign or removal. | ||
| // Configures a worker's polling for sessions that keep workflow and activity | ||
| // tasks on a stable worker destination. Activities opt into session routing | ||
| // through ActivitySessionOptions on their scheduling commands. | ||
| message WorkerSessionOptions { | ||
| oneof isolation { | ||
| SingleSessionOptions single_session = 1; | ||
| } | ||
| } | ||
|
|
||
| // EXPERIMENTAL. Subject to redesign or removal. | ||
| // Dedicates a sticky destination to the first workflow matched to it. | ||
| // Workflow sticky polls may be forwarded to the normal queue until the first | ||
| // workflow task is dispatched. The server persists that workflow ID and does | ||
| // not forward subsequent polls, including after workflow completion. | ||
| // Activity sticky polls are never forwarded to the normal queue. | ||
| message SingleSessionOptions { | ||
|
Member
Author
There was a problem hiding this comment. thomas: says that maybe we should think about what this is called if we wanna ActivitySessionOptions
|
||
| // Stable sticky task queue name, shared by workflow and activity polls. | ||
| // Reuse this value across worker restarts within the same session, but not | ||
| // across concurrently running workers. This is distinct from worker identity. | ||
| // The SDK must also set the polled sticky task queue's name to this value. | ||
| string stable_identity = 1; | ||
| } | ||
|
|
||
| message ActivitySessionOptions { | ||
|
Member
Author
There was a problem hiding this comment. i envision these options to be sent on the command attributes when we are going to schedule an activity task -- if that is the case, i wonder if we should have something defined or thought of for the stable identity piece (single session isolation) given that we seem to have thought this in the poll request structures if not, then i wonder if we do even need the single session options defined in the general WorkerSessionOptions |
||
| oneof session { | ||
| // Execute this activity as part of its workflow's session. | ||
| // Currently routes to the workflow's sticky task queue when true. | ||
| bool use_workflow_session = 1; | ||
|
|
||
| // later session_id, etc | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also have a boolean for use_workflow_session here?