SCAL-325090 Add PreRenderConfig to control iframe z-index - #603
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
commit: |
shivam-kumar-ts
changed the title
shivam-kumar-ts
force-pushed
the
SCAL-325090
branch
from
July 31, 2026 08:05
d703135 to
069ea7b
Compare
sastaachar
requested changes
Aug 4, 2026
sastaachar
requested changes
Aug 5, 2026
shivam-kumar-ts
force-pushed
the
SCAL-325090
branch
from
August 5, 2026 10:51
1dc07dd to
90b3631
Compare
sastaachar
requested changes
Aug 5, 2026
shivam-kumar-ts
force-pushed
the
SCAL-325090
branch
from
August 7, 2026 07:56
e4feb56 to
1ebece3
Compare
sastaachar
approved these changes
Aug 10, 2026
bahetirisabh
added a commit
to bahetirisabh/visual-embed-sdk
that referenced
this pull request
Aug 10, 2026
Picks up SpotterAnalystList, SpotterDefaultAnalyst and SpotterEmbedViewConfig.analystId. Also picks up drift already on main whose commits did not regenerate the docs: preRenderConfig from thoughtspot#603, and the enum-name corrections from thoughtspot#615 (EmbedEvent.customAction -> CustomAction, EmbedEvent.DrillDown -> Drilldown, ListPageColumns.Favorite -> Favorites, AuthEvent.SUCCESS -> AuthStatus.SUCCESS, and the removal of the non-existent HostEvent.ScheduleList examples). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces PreRenderConfig interface and preRenderConfig property on BaseViewConfig to group all pre-render settings into a single config object
Adds zIndex to control the hidden wrapper's CSS z-index (default -1000), fixing cases where the hidden pre-render bleeds above other page content in shallow stacking contexts
Migrates preRenderId, preRenderContainer, and doNotTrackPreRenderSize into PreRenderConfig for backward compatibility — preRenderConfig.* takes precedence when both are set, existing top-level usage continues to work unchanged
Adds @default tags and fixes tag ordering on all preRender-related JSDoc in BaseViewConfig