fix(adaptive): judge blocker taxonomy + tool argument facts - #59
Conversation
Two field findings from driving the loop on a live host:
- The judge classified a retryable command error (a bad CLI flag) as
terminal missing_evidence, ending an episode with budget remaining.
The taxonomy now states it: mechanical failures — a miswired binding,
a bad flag, a refused tool call — are goal_not_met, because the graph
can be changed; missing_evidence is for goals where another attempt
meets the same nothing; and the terminal labels are chosen only when
retrying genuinely cannot help.
- HostFacts advertised tools as bare slugs, so an author invented
`args.command` for a shell tool — twice, spending the episode on a
key name it was never shown. ToolFact { slug, args } carries each
tool's argument shape in prose, rendered one line per tool into the
authoring prompt, covered by is_unknown and the configured-alone test.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedFailed to post review comments. GitHub was unavailable or timed out while CodeRabbit was posting the review. Please request a new review later if the pull request still needs one. This happened while posting 2 inline comments. Use ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 🧰 Additional context used📓 Path-based instructions (1)**/*.rs📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧠 Learnings (1)📚 Learning: 2026-08-17T06:47:19.808ZApplied to files:
📝 WalkthroughWalkthroughThe change adds documented tool argument shapes to ChangesAdaptive context and closing
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: 🟡 Moderate · up to The PR improves retry classification and tool argument guidance, but it can still end retryable episodes too early and may break downstream users that construct the public host-facts struct directly. These issues should be fixed or explicitly accepted before merging. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Two independent field findings (see commit message): (1) the judge classified a retryable command error as terminal
missing_evidence, ending an episode with budget remaining — the taxonomy now states that mechanical failures aregoal_not_met(the graph can change),missing_evidencemeans another attempt meets the same nothing, and terminal labels are for when retrying genuinely cannot help; (2)HostFactsadvertised tools as bare slugs, so an author inventedargs.commandfor a shell tool twice —ToolFact { slug, args }now carries each tool's argument shape, rendered per tool into the authoring prompt, covered byis_unknownand the configured-alone test.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes