Repository navigation
Don't complete speech a second time when the engine reports stopping after an interrupt - #110
Merged
Conversation
…after an interrupt
aaron-gh
added a commit
to aaron-gh/backtalk
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When something interrupts speech, such as touching the screen, the speech controller completes the current item itself: it tells its observers, releases audio focus, and clears the current item. The speech engine then reports that the utterance stopped. With no current item, that report wasn't recognised as stale, so speech was completed again: "Completed speech while already completed!" was logged, audio focus was released two or three times in a row, and observers were told twice.
Now completing speech that has already completed does nothing, except that a pause is still reported to observers, since that is only known when the engine's stop arrives.
Testing