Skip to content

Don't complete speech a second time when the engine reports stopping after an interrupt #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trypsynth merged 1 commit into from
Oct 8, 2026
+12 −4
Merged

Don't complete speech a second time when the engine reports stopping after an interrupt #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions utils/src/main/java/com/google/android/accessibility/utils/output/SpeechControllerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2225,6 +2225,18 @@ private boolean isAssistantPlaying() {
* @see #handleSpeechStarting()
*/
private void handleSpeechCompleted(int status) {
if (!mIsSpeaking) {
// Speech already completed, such as when an interrupt completes the current item and the
// engine then reports that it stopped. Audio focus was released then, and observers told,
// except that a pause that stopped the speech is only known now.
if (status == STATUS_PAUSE) {
for (SpeechController.Observer observer : observers) {
observer.onSpeechPaused();
}
}
return;
}

for (SpeechController.Observer observer : observers) {
if (status == STATUS_PAUSE) {
observer.onSpeechPaused();
Expand All @@ -2242,10 +2254,6 @@ private void handleSpeechCompleted(int status) {
}
}

if (!mIsSpeaking) {
LogUtils.e(TAG, "Completed speech while already completed!");
}

mIsSpeaking = false;
}

Expand Down
Loading