Skip to content

PLAT-1314/feat: support a dedicated twoctl config directory - #7

Merged
brtkwr merged 1 commit into
mainfrom
bkunwar/plat-1314-config-home
Oct 29, 2026
Merged

brtkwr merged 1 commit into
mainfrom
bkunwar/plat-1314-config-home

Conversation

@brtkwr

@brtkwr brtkwr commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Context

PLAT-1314 calls for a twoctl-specific configuration-directory override. Today scripts have to change XDG_CONFIG_HOME for every application or share twoctl's normal context and update-preference files.

Changes

  • Honor non-empty TWOCTL_CONFIG_HOME as the exact directory for config.yaml, its lock, and updater state.json.
  • Preserve the existing XDG/home fallback when the override is absent or empty.
  • Document precedence, existing-file behavior, and the separate OS-keychain scope; add read/write regression tests for both context configuration and updater state.

Scope / Non-goals

No files are migrated and credential storage remains in the OS keychain under existing context names. This is independent of retry-controls PR #6 and implements one incremental PLAT-1314 requirement.

Validation

On head a780d43136954027c2151a83e32e147241135d73, CI run 40853928234 passed both jobs:

  • build: go build ./... and make test-cover passed; all tests passed and total coverage 80.7% exceeds the 80% gate.
  • lint: all repository lints passed, including formatting, vet, ineffassign, spelling, complexity, and golint.
  • No tests run locally. Local formatting and git diff --check passed.

Ticket

Refs PLAT-1314.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T10:00:34.275357Z a780d43 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@brtkwr
brtkwr merged commit 0479c82 into main Oct 29, 2026
2 checks passed
@brtkwr
brtkwr deleted the bkunwar/plat-1314-config-home branch October 29, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant