Repository navigation
PLAT-1314/feat: select invocation context through TWOCTL_CONTEXT - #8
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 29, 2026
Puvendhan
approved these changes
Oct 29, 2026
Puvendhan
left a comment
There was a problem hiding this comment.
LGTM. TWOCTL_CONTEXT sits after --context and --env and never writes the saved context. pickContext uses it for the auth commands. The dry-run placeholder key only lets URL resolution run without a keychain read, and it is not sent. Needs a rebase after #6, or the other way round.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PLAT-1314 specifies an environment-variable context override for headless scripts. twoctl currently requires a flag on every invocation or a change to the shared saved context.
Changes
--context, then--env, then non-emptyTWOCTL_CONTEXT, then the saved current context.--urlexplicit-key boundary.Scope / Non-goals
This is one coherent PLAT-1314 context-selection feature. It starts from main after merged PR #7 and does not depend on open retry-controls PR #6. OS-keychain storage and configuration mutation commands retain their existing behavior.
Validation
On exact head
817cfb2c43b2ce1c34f92e2f13a752231602f188, CI run 40854811107 passed both jobs:go build ./..., all tests throughmake test-cover, and the 80% coverage gate passed. Total coverage: 81.0%.git diff --checkpassed.Ticket
Refs PLAT-1314.
✨ via Codex session