Repository navigation
PLAT-1314/feat: expose per-request retry limits in twoctl - #6
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 29, 2026
Puvendhan
approved these changes
Oct 29, 2026
Puvendhan
left a comment
There was a problem hiding this comment.
LGTM. --max-retries is applied to ordinary and paginated requests through one client builder. Negative values return a usage error. DisableRetries makes 0 mean a single attempt instead of falling back to the default. #8 also touches root.go and operations.go, so the second one to merge will need a rebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
twoctl always retries transient API failures three times. Scripts cannot opt out or choose a smaller retry count, despite the retry controls in PLAT-1314.
Changes
--max-retries Nto API operations, including each request made by--all.--max-retries 0send one attempt, preserve three retries by default, and reject negative counts before sending a request.Scope / Non-goals
This implements the retry-count control from the incremental PLAT-1314 checklist. The retry budget flag and other checklist items remain separate work. Existing request timeout, backoff, and idempotency semantics are preserved.
Validation
On head
e15f8cec57c503807c8907b67bceb2c5f11f5715, CI run 40853289965 passed both jobs:go build ./...andmake test-coverpassed, including all unit tests; total coverage 80.4% exceeds the 80% gate../scripts/lint.shpassed (formatting, vet, ineffassign, misspell, complexity, golint).git diff --checkpassed.Ticket
Refs PLAT-1314.
✨ via Codex session