Skip to content

uucore: build without default features on Unix #15362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
limadog9 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

uucore: build without default features on Unix #15362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/CICD.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ jobs:
unset CARGO_FEATURES_OPTION
if [ -n "${{ matrix.job.features }}" ]; then CARGO_FEATURES_OPTION='--features "${{ matrix.job.features }}"' ; fi
outputs CARGO_FEATURES_OPTION
- name: Check uucore without default features
run: |
cargo check -p uucore --no-default-features --lib --locked
cargo check -p uucore --no-default-features --features fs --lib --locked
- name: Confirm MinSRV compatible '*/Cargo.lock'
shell: bash
run: |
Expand Down
3 changes: 2 additions & 1 deletion src/uucore/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,10 @@ dns-lookup = { workspace = true, optional = true }
rustix = { workspace = true, optional = true }

[target.'cfg(unix)'.dependencies]
# Core error conversions and signal setup use nix even without optional features.
nix = { workspace = true, features = ["signal"] }
# utmpx is unix-only, so its dependencies must not be pulled into other targets
# (the uptime feature enables utmpx and now builds on windows too).
nix = { workspace = true, optional = true }
time = { workspace = true, optional = true, features = [
"formatting",
"local-offset",
Expand Down
Loading