Repository navigation
Conversation
|
|
||
| [features] | ||
| default = ["signals"] | ||
| # Preserve the former optional dependency feature for downstream users. |
There was a problem hiding this comment.
What is the usecase for this?
There was a problem hiding this comment.
This preserves the implicit nix feature previously exposed by optional = true. Removing it would reject downstream manifests explicitly enabling features = ["nix"]. There’s no known in-tree consumer; it’s precautionary compatibility and adds no runtime behavior.
There was a problem hiding this comment.
Downstream should just remove it. No?
There was a problem hiding this comment.
Thanks. Wait maintainer's review.
Make nix a required Unix dependency with signal support and check uucore without default features in isolation. Closes uutils#15339
70c67f2 to
ccb86ea
Compare
Merging this PR will degrade performance by 4.63%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | factor_three_39_bit_primes |
567 ms | 644.4 ms | -12.01% |
| ⚡ | Simulation | factor_thirteen_39_bit_primes |
9.5 s | 9.2 s | +3.37% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing limadog9:fix/uucore-no-default-features (ccb86ea) with main (7654e67)
Footnotes
-
70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
I've got a better fix for this in a branch somewhere... |
|
Superseded by #15372. |
Closes #15339