Skip to content

uucore: build with --no-default-features - #15372

Open
xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:GH15339
Open

xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:GH15339

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #15339.
Closes #15362.

cargo clippy -q -p uucore --all-targets --no-default-features

@xtqqczze
xtqqczze force-pushed the GH15339 branch 2 times, most recently from b12d4c7 to 7d43fbf Compare October 15, 2026 13:31
@xtqqczze xtqqczze changed the title fixup! uucore: print "Operation not permitted" for EPERM uucore: build with --no-default-features Oct 15, 2026
@codspeed

codspeed Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 3.86%

⚠️ 120 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

⚡ 2 improved benchmarks
❌ 2 regressed benchmarks
✅ 397 untouched benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ ⚠️ Simulation csplit_line_number 48 ms 56.3 ms -14.82%
❌ Simulation csplit_regex_pattern 66.3 ms 73.7 ms -10.04%
⚡ Simulation factor_three_39_bit_primes 598.6 ms 561.1 ms +6.68%
⚡ Simulation factor_five_38_bit_primes 1.9 s 1.8 s +4.53%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:GH15339 (c545582) with main (175f6e1)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (4945ecf) during the generation of this report, so 175f6e1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Use `libc::EPERM` instead of `nix::errno::Errno::EPERM` to avoid referencing the optional `nix` dependency when it is not enabled.
@xtqqczze
xtqqczze force-pushed the GH15339 branch 2 times, most recently from 00ab636 to 22d3dfe Compare October 16, 2026 00:26
```sh
cargo clippy -q -p uucore --all-targets --no-default-features
```

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uucore: doesn't build with --no-default-features

1 participant