Repository navigation
refactor(create): run remote templates through vp dlx - #3478
jong-kyung wants to merge 3 commits into
Conversation
Replace the package runner table in create with `vp dlx`, which already owns the same resolution in vp_pm_cli. Pass the selected package manager through VP_PACKAGE_MANAGER because `vp dlx` detects it from the working directory and defaults to pnpm outside a project.
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d00d060372
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A VP_PACKAGE_MANAGER override can carry an integrity hash, and vp_pm_cli stores a hashed install in a separate verified directory. Replacing the override with a bare name and version made `vp dlx` download the package manager again without the hash and run that copy. Keep the user's value so the template runs with the install that create verified.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd25243292
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Without the terminator, the global CLI read a template's --help as a request for vp dlx help, so the generator never ran.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4945ec9ce6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const envs = templateInfo.envs; | ||
| const { command, args } = formatDlxCommand(remotePackageName, execArgs, workspaceInfo); | ||
| // `--` keeps the global CLI from reading a template's `--help` as its own. | ||
| const dlxArgs = ['dlx', '--', templateInfo.command, ...templateInfo.args]; |
There was a problem hiding this comment.
Preserve the npm 6 fallback when delegating templates to dlx
With VP_PACKAGE_MANAGER=npm@6.14.18, both local and global creation now reach Npm::resolve in crates/vp_pm_cli/src/resolution/commands/dlx.rs, which unconditionally constructs npm exec --yes. npm 6 has npx but no exec subcommand; npm's compatibility documentation dates the rewrite to v7.0.0 and explains that “npx uses the npm exec command instead of a separate argument parser and install process.” Consequently remote scaffolding no longer runs the generator with this supported package-manager version, whereas the removed runner invoked npx. Add a version-gated npx fallback to the shared dlx resolver.
AGENTS.md reference: AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
vp createnow runs remote templates throughvp dlxinstead of its own package runner table, which duplicated the resolution invp_pm_cli. The selected package manager is passed throughVP_PACKAGE_MANAGER, becausevp dlxdefaults to pnpm outside a project.