Skip to content

Port PiecewiseSequence run-take consumers #8802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danking wants to merge 3 commits into
base: codex/piecewise-sequential-take
Choose a base branch
from
+700 −87
Draft

Port PiecewiseSequence run-take consumers #8802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04ee240
Port PiecewiseSequence run take consumers
danking Jul 16, 2026
b4fbd0f
Use unit multipliers for PiecewiseSequence consumers
danking Jul 16, 2026
de584c6
Specialize constant PiecewiseSequence runs
danking Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vortex-array/src/arrays/extension/compute/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ use crate::arrays::ConstantArray;
use crate::arrays::Extension;
use crate::arrays::ExtensionArray;
use crate::arrays::Filter;
use crate::arrays::dict::TakeReduceAdaptor;
use crate::arrays::extension::ExtensionArrayExt;
use crate::arrays::filter::FilterReduceAdaptor;
use crate::arrays::slice::SliceReduceAdaptor;
Expand Down Expand Up @@ -50,6 +51,7 @@ pub(crate) const PARENT_RULES: ParentRuleSet<Extension> = ParentRuleSet::new(&[
ParentRuleSet::lift(&FilterReduceAdaptor(Extension)),
ParentRuleSet::lift(&MaskReduceAdaptor(Extension)),
ParentRuleSet::lift(&SliceReduceAdaptor(Extension)),
ParentRuleSet::lift(&TakeReduceAdaptor(Extension)),
]);

/// Push filter operations into the storage array of an extension array.
Expand Down
16 changes: 16 additions & 0 deletions vortex-array/src/arrays/extension/compute/take.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,24 @@ use crate::array::ArrayView;
use crate::arrays::Extension;
use crate::arrays::ExtensionArray;
use crate::arrays::dict::TakeExecute;
use crate::arrays::dict::TakeReduce;
use crate::arrays::extension::ExtensionArrayExt;

impl TakeReduce for Extension {
fn take(array: ArrayView<'_, Extension>, indices: &ArrayRef) -> VortexResult<Option<ArrayRef>> {
let taken_storage = array.storage_array().take(indices.clone())?;
Ok(Some(
ExtensionArray::new(
array
.ext_dtype()
.with_nullability(taken_storage.dtype().nullability()),
taken_storage,
)
.into_array(),
))
}
}

impl TakeExecute for Extension {
fn take(
array: ArrayView<'_, Extension>,
Expand Down
Loading
Loading