docs(openspec): propose observability diagnostics for node-vtex-api@6.x - #710
Open
juliobguedes wants to merge 2 commits into
Open
juliobguedes wants to merge 2 commits into
juliobguedes wants to merge 2 commits into
Conversation
|
![dk-pr-review[bot]](https://avatars.githubusercontent.com/in/4406719?s=60&v=4){kind=small}
There was a problem hiding this comment.
DK Review — Deferred (Sonar gate)
⏭️ LLM review not run: this PR's Sonar quality gate is currently failing.
DK Review holds the AI review until Sonar passes, so review budget is not spent on a PR that already needs changes. Fix the issues Sonar reported and push again — the full review runs automatically once Sonar is green.
This PR is not blocked by DK Review; a human engineer can still approve and merge manually.
DK Review v1.0.0
5 tasks
Adds an OpenSpec change (proposal, design, TDD/BDD specs, and tasks) for backporting DiagnosticsMetrics and the split traces/metrics/logs telemetry client from master to the 6.x branch, now that the dependency audit shows no Node engine blocker under the node:6.x builder runtime. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
juliobguedes
force-pushed
the
feature/add-observability-to-6x-openspec
branch
from
September 17, 2026 14:10
8732737 to
2d0eddc
Compare
…ity-to-6x The first implementation pass (PR #711) ported the DiagnosticsMetrics API and telemetry client, but not the wiring that actually calls them per request. Deploying 6.53.0-beta.0 to the iotest-ju2 test cluster confirmed no metrics reached ClickHouse despite the feature flag being enabled, because: - service/index.ts never calls initializeTelemetry() or sets global.diagnosticsMetrics - none of master's five consumer call sites (timings.ts, requestStats.ts, HttpClient/middlewares/metrics.ts, HttpAgentSingleton.ts, the @Metric GraphQL directive) exist on 6.x yet Updates proposal.md, design.md, and specs/diagnostics-metrics/spec.md to cover this wiring (new BDD requirements: boot-time initialization, request-pipeline metric emission, graceful degradation), and rewrites tasks.md as a single source of truth reflecting what's actually done (groups 1-7, 9.1, 9.3, 10.1) versus what's still pending (new group 8: the wiring itself, plus 9.2/9.4/10.2). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
daniyelnnr
approved these changes
Sep 17, 2026
daniyelnnr
left a comment
daniyelnnr
left a comment
Contributor
There was a problem hiding this comment.
LGTM, the spec is clear and easy to understand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add-observability-to-6x) proposing the backport ofDiagnosticsMetricsand the split traces/metrics/logs telemetry client frommaster(7.x) tonode-vtex-api@6.x.engines.nodefloor is>=14, well within thenode: 6.xbuilder runtime (Node 16.20.2). Nobuilder-hub/service-runtime-nodechanges are required.proposal.md,design.md,specs/diagnostics-metrics/spec.md,tasks.md).Test plan
openspec validate --changes add-observability-to-6xpasses (already run locally)6.xbranch6.xbranch🤖 Generated with Claude Code