Skip to content

fix: restore corrupted Flat Paint translations - #92

Merged
vycdev merged 1 commit into
developfrom
claude/gracious-maxwell-co6wqh
Oct 18, 2026
Merged

vycdev merged 1 commit into
developfrom
claude/gracious-maxwell-co6wqh

Conversation

@vycdev

@vycdev vycdev commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the ?? text flagged in the v4.2.0 release review (#91).

c580460 saved several locale strings with a lossy encoding, so every character outside the encoding became ?. This PR repairs all 18 affected strings, not only the 5 flagged:

  • The new Flat Paint guide paragraph (line 18 of src/locales/*/docs/flat-paint.md) in all 11 translated languages.
    • French, German, Italian, Romanian, Spanish and Portuguese lost their accented letters ("z?hlt", "n?o"). This restores them character by character.
    • Bengali, Hindi, Japanese, Ukrainian and Chinese lost almost the whole sentence. These are retranslated from the English source, using the terms each guide already uses for carrier, foundation, slab, Layer Preview and the Build 3D Model button.
  • runtime.flatPaintPartProgress in printing.json for bn, fr, hi, ja, ro, uk and zh-CN. de, es, it and pt-PT were unaffected.

The retranslations of the ja, uk and zh-CN progress labels match the character counts still visible in the corrupted strings.

Two related corrections from the same unreviewed commit:

  • Line 18 used the English label Build 3D Model in every translated paragraph. It now uses each language's button name.
  • The adjacent build-failure paragraph (line 20) named the button or Layer Preview differently from the app and the other guides in fr, ro, es, pt-PT, zh-CN, uk, it, hi and bn. It now uses the same names.

No other files from c580460 or main..develop show this corruption. A scan for ? inside or between letters across src/locales finds only URL query strings and genuine French questions.

Validation

  • npm run check:i18n, npm run test:i18n (10 passed) and npm run test:docs (3 passed).
  • 860 Node regression tests: 859 passed, 1 skipped (it requires Windows and NSIS).
  • npm run test:e2e:i18n:build: production build and all 4 i18n browser tests passed, using the container's preinstalled Chromium.
  • Every changed JSON file parses, and git diff --check is clean.

Native-speaker review of the retranslated bn, hi, ja, uk and zh-CN text is welcome.


Generated by Claude Code

Commit c580460 saved several locale strings with a lossy encoding, so
non-ASCII characters became "?". Restore the affected Flat Paint guide
paragraph in all 11 translated languages and the flatPaintPartProgress
build-progress label in bn, fr, hi, ja, ro, uk, and zh-CN. Latin-script
text is restored character for character; Bengali, Hindi, Japanese,
Ukrainian, and Chinese text is retranslated from the English source with
each guide's existing terminology.

The adjacent build-failure paragraph now uses the same Build 3D Model and
Layer Preview names as the app and the other guides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qf5SDDTLr39hMsXWkdPkFL
@vycdev
vycdev merged commit ed6da31 into develop Oct 18, 2026
@vycdev vycdev mentioned this pull request Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants